Skip to content
This repository was archived by the owner on Sep 21, 2020. It is now read-only.

Commit e5e239f

Browse files
keilwkeilw
committed
Verify UCUM formatting #4
Task-Url: #4
1 parent b45827f commit e5e239f

1 file changed

Lines changed: 93 additions & 104 deletions

File tree

‎src/test/java/com/opower/unitsofmeasure/TestUnitJacksonModule.java‎

Lines changed: 93 additions & 104 deletions
Original file line numberDiff line numberDiff line change
@@ -27,108 +27,97 @@
2727
* Unit tests for UnitJacksonModule
2828
*/
2929
public class TestUnitJacksonModule {
30-
// can't directly unit test the Jackson Module classes; need to go through JsonFactory
31-
private JsonFactory jsonFactory;
32-
33-
@Before
34-
public void setUp() throws Exception {
35-
final ObjectMapper mapper = new ObjectMapper();
36-
mapper.registerModule(new UnitJacksonModule());
37-
this.jsonFactory = new JsonFactory(mapper);
38-
}
39-
40-
@Test
41-
public void testSerializeArea() throws Exception {
42-
assertEquals(
43-
"Expected JSON with a UCUM representation of the area unit",
44-
"\"m2\"", serialize(Units.SQUARE_METRE));
45-
}
46-
47-
@Test
48-
public void testSerializeTemperature() throws Exception {
49-
assertEquals(
50-
"Expected JSON with a UCUM representation of the temperature unit",
51-
"\"[degF]\"", serialize(UCUM.FAHRENHEIT));
52-
assertEquals(
53-
"Expected JSON with a UCUM representation of the temperature unit",
54-
"\"Cel\"", serialize(Units.CELSIUS));
55-
}
56-
57-
@Test
58-
public void testSerializeLength() throws Exception {
59-
assertEquals(
60-
"Expected JSON with a UCUM representation of the length unit",
61-
"\"[mi_i]\"", serialize(UCUM.MILE_INTERNATIONAL));
62-
63-
assertEquals(
64-
"Expected JSON with a UCUM representation of the length unit",
65-
"\"m\"", serialize(Units.METRE));
66-
67-
// assertEquals(
68-
// "Expected JSON with a UCUM representation of the length unit",
69-
// "\"km\"", serialize(KILO(Units.METRE))); //TODO solve prefix formatting
70-
//
71-
// assertEquals(
72-
// "Expected JSON with a UCUM representation of the length unit",
73-
// "\"mm\"", serialize(MILLI(Units.METRE)));
74-
}
75-
76-
@Test
77-
public void testSerializeSpeed() throws Exception {
78-
assertEquals(
79-
"Expected JSON with a UCUM representation of the speed unit",
80-
"\"[kph]\"", serialize(Units.KILOMETRE_PER_HOUR));
81-
}
82-
83-
@Test
84-
public void testParseArea() throws Exception {
85-
Unit<?> parsedUnit = parse("\"[sft_i]\"", Unit.class);
86-
87-
assertEquals("The Unit<Area> in the parsed JSON doesn't match",
88-
UCUM.SQUARE_FOOT_INTERNATIONAL, parsedUnit);
89-
}
90-
91-
@Test
92-
public void testParseTemperature() throws Exception {
93-
Unit<?> parsedUnit = parse("\"Cel\"", Unit.class);
94-
assertEquals("The Unit<Temperature> in the parsed JSON doesn't match",
95-
Units.CELSIUS, parsedUnit);
96-
}
97-
98-
@Test
99-
public void testParseLength() throws Exception {
100-
Unit<?> parsedUnit = parse("\"m\"", Unit.class);
101-
assertEquals("The Unit<Length> in the parsed JSON doesn't match",
102-
Units.METRE, parsedUnit);
103-
}
104-
105-
@Test(expected = JsonParseException.class)
106-
public void testParseWithUnrecognizedField() throws Exception {
107-
parse("foobar", Unit.class);
108-
}
109-
110-
@Test
111-
@Ignore("solve km formatting") // TODO solve km parsing
112-
public void testParseLengthKm() throws Exception {
113-
Unit<?> parsedUnit = parse("\"km\"", Unit.class);
114-
assertEquals("The Unit<Length> in the parsed JSON doesn't match",
115-
KILO(Units.METRE), parsedUnit);
116-
}
117-
118-
protected String serialize(Object objectToSerialize) throws IOException {
119-
final Writer writer = new StringWriter();
120-
final JsonGenerator generator = this.jsonFactory.createJsonGenerator(writer);
121-
122-
generator.writeObject(objectToSerialize);
123-
generator.close();
124-
return writer.toString();
125-
}
126-
127-
protected <T> T parse(String json, Class<T> aClass) throws IOException {
128-
final JsonParser parser = this.jsonFactory.createJsonParser(json);
129-
T object = parser.readValueAs(aClass);
130-
131-
parser.close();
132-
return object;
133-
}
30+
// can't directly unit test the Jackson Module classes; need to go through
31+
// JsonFactory
32+
private JsonFactory jsonFactory;
33+
34+
@Before
35+
public void setUp() throws Exception {
36+
final ObjectMapper mapper = new ObjectMapper();
37+
mapper.registerModule(new UnitJacksonModule());
38+
this.jsonFactory = new JsonFactory(mapper);
39+
}
40+
41+
@Test
42+
public void testSerializeArea() throws Exception {
43+
assertEquals("Expected JSON with a UCUM representation of the area unit", "\"m2\"",
44+
serialize(Units.SQUARE_METRE));
45+
}
46+
47+
@Test
48+
public void testSerializeTemperature() throws Exception {
49+
assertEquals("Expected JSON with a UCUM representation of the temperature unit", "\"[degF]\"",
50+
serialize(UCUM.FAHRENHEIT));
51+
assertEquals("Expected JSON with a UCUM representation of the temperature unit", "\"Cel\"",
52+
serialize(Units.CELSIUS));
53+
}
54+
55+
@Test
56+
@Ignore("address https://github.com/unitsofmeasurement/uom-systems/issues/74")
57+
public void testSerializeLength() throws Exception {
58+
assertEquals("Expected JSON with a UCUM representation of the length unit", "\"[mi_i]\"",
59+
serialize(UCUM.MILE_INTERNATIONAL));
60+
61+
assertEquals("Expected JSON with a UCUM representation of the length unit", "\"m\"", serialize(Units.METRE));
62+
63+
assertEquals("Expected JSON with a UCUM representation of the length unit", "\"km\"",
64+
serialize(KILO(Units.METRE))); // TODO solve prefix formatting
65+
66+
assertEquals("Expected JSON with a UCUM representation of the length unit", "\"mm\"",
67+
serialize(MILLI(Units.METRE)));
68+
}
69+
70+
@Test
71+
public void testSerializeSpeed() throws Exception {
72+
assertEquals("Expected JSON with a UCUM representation of the speed unit", "\"[kph]\"",
73+
serialize(Units.KILOMETRE_PER_HOUR));
74+
}
75+
76+
@Test
77+
public void testParseArea() throws Exception {
78+
Unit<?> parsedUnit = parse("\"[sft_i]\"", Unit.class);
79+
80+
assertEquals("The Unit<Area> in the parsed JSON doesn't match", UCUM.SQUARE_FOOT_INTERNATIONAL, parsedUnit);
81+
}
82+
83+
@Test
84+
public void testParseTemperature() throws Exception {
85+
Unit<?> parsedUnit = parse("\"Cel\"", Unit.class);
86+
assertEquals("The Unit<Temperature> in the parsed JSON doesn't match", Units.CELSIUS, parsedUnit);
87+
}
88+
89+
@Test
90+
public void testParseLength() throws Exception {
91+
Unit<?> parsedUnit = parse("\"m\"", Unit.class);
92+
assertEquals("The Unit<Length> in the parsed JSON doesn't match", Units.METRE, parsedUnit);
93+
}
94+
95+
@Test(expected = JsonParseException.class)
96+
public void testParseWithUnrecognizedField() throws Exception {
97+
parse("foobar", Unit.class);
98+
}
99+
100+
@Test
101+
@Ignore("solve km formatting") // TODO solve km parsing
102+
public void testParseLengthKm() throws Exception {
103+
Unit<?> parsedUnit = parse("\"km\"", Unit.class);
104+
assertEquals("The Unit<Length> in the parsed JSON doesn't match", KILO(Units.METRE), parsedUnit);
105+
}
106+
107+
protected String serialize(Object objectToSerialize) throws IOException {
108+
final Writer writer = new StringWriter();
109+
final JsonGenerator generator = this.jsonFactory.createJsonGenerator(writer);
110+
111+
generator.writeObject(objectToSerialize);
112+
generator.close();
113+
return writer.toString();
114+
}
115+
116+
protected <T> T parse(String json, Class<T> aClass) throws IOException {
117+
final JsonParser parser = this.jsonFactory.createJsonParser(json);
118+
T object = parser.readValueAs(aClass);
119+
120+
parser.close();
121+
return object;
122+
}
134123
}

0 commit comments

Comments
 (0)