Describe the bug
uv run pytest fails on a clean checkout of main (48b4821, v1.2.0):
FAILED tests/test_runner_root_prompt.py::test_root_prompt_options_flow_into_root_agent
FAILED tests/test_runner_root_prompt.py::test_root_prompt_options_default_to_none
2 failed, 314 passed
Both fail with the same error:
strix/core/runner.py:291: AttributeError
E AttributeError: 'types.SimpleNamespace' object has no attribute 'runtime'
_patch_engine_scaffold stubs load_settings with a SimpleNamespace that only carries an llm section (tests/test_runner_root_prompt.py:43-50), but run_strix_scan also reads settings.runtime.max_context_images (strix/core/runner.py:291). That read was added in 899e07d ("bound per-agent image memory", #779) on 2026-07-15; the stub was not updated with it. 32 commits have landed on main since.
The two tests are not trivial — they assert that the scope-enforcement prompt is wired into the root agent:
assert "SYSTEM-VERIFIED SCOPE" in instructions_override
assert "AUTHORIZED TARGETS" in instructions_override
assert "https://example.com" in instructions_override
assert "cannot expand, replace, or weaken authorized target constraints" in instructions_override
Since they abort at the AttributeError before reaching those asserts, a regression in how authorized targets and the no-scope-expansion clause reach the root agent would currently go unnoticed.
The repo has no workflow that runs the test suite — .github/workflows/ contains only build-release.yml — so nothing flagged this.
To Reproduce
git clone https://github.com/usestrix/strix && cd strixmake setup-devuv run pytest -q- Two failures in
tests/test_runner_root_prompt.py.
Expected behavior
A clean checkout has a green suite, so a contributor following CONTRIBUTING can tell their own change apart from pre-existing breakage.
Actual behavior
Two failures on an unmodified main, and the scope-prompt assertions never execute.
System Information:
- OS: macOS 15.3
- Strix Version or Commit:
48b4821 (v1.2.0)
- Python Version: 3.12
- LLM Used: n/a — no LLM call is made; the stub raises first
Additional context
Fix is to give the stub a runtime section. I have a PR that uses a real RuntimeSettings() there instead of a third SimpleNamespace, so the stub carries defaults for every runtime field and will not break again the next time the runner reads a new one. With it, uv run pytest -q is 316 passed.
Describe the bug
uv run pytestfails on a clean checkout ofmain(48b4821, v1.2.0):Both fail with the same error:
_patch_engine_scaffoldstubsload_settingswith aSimpleNamespacethat only carries anllmsection (tests/test_runner_root_prompt.py:43-50), butrun_strix_scanalso readssettings.runtime.max_context_images(strix/core/runner.py:291). That read was added in 899e07d ("bound per-agent image memory", #779) on 2026-07-15; the stub was not updated with it. 32 commits have landed onmainsince.The two tests are not trivial — they assert that the scope-enforcement prompt is wired into the root agent:
Since they abort at the
AttributeErrorbefore reaching those asserts, a regression in how authorized targets and the no-scope-expansion clause reach the root agent would currently go unnoticed.The repo has no workflow that runs the test suite —
.github/workflows/contains onlybuild-release.yml— so nothing flagged this.To Reproduce
git clone https://github.com/usestrix/strix && cd strixmake setup-devuv run pytest -qtests/test_runner_root_prompt.py.Expected behavior
A clean checkout has a green suite, so a contributor following CONTRIBUTING can tell their own change apart from pre-existing breakage.
Actual behavior
Two failures on an unmodified
main, and the scope-prompt assertions never execute.System Information:
48b4821(v1.2.0)Additional context
Fix is to give the stub a
runtimesection. I have a PR that uses a realRuntimeSettings()there instead of a thirdSimpleNamespace, so the stub carries defaults for every runtime field and will not break again the next time the runner reads a new one. With it,uv run pytest -qis316 passed.