Today — ci.yml runs the whole suite on windows-latest as windows (non-required): continue-on-error: true, and not in required-green's needs. That is step 4 of #149 as written — non-required at first, then required — and this issue is the "then".
The leg's first run on #279 was already green after the #[cfg_attr(windows, ignore = "…")] pass (358 passed, 0 failed, 82 ignored on the dispatch workflow; the CI leg itself green once env_clear_blocks_inheritance… probed USERPROFILE instead of HOME). What it has not yet shown is that it stays green: ConPTY behaviour on the runner image, cargo build -p of the fixtures from inside the tests on a Windows filesystem, and the two liveness paths #277 synthesizes from try_wait are all things a few weeks of PRs will exercise more honestly than one run did.
Fix — two edits, written next to the job: drop continue-on-error, add windows to required-green's needs. Consider at the same time whether windows.yml's suite step is still worth keeping alongside the probe, now that the leg runs the suite on every PR.
Done when — the leg has been green on every push to main for a stretch long enough to trust (a release cycle is a natural one), required-green needs it, and CONTRIBUTING §1 still lists the one command it runs.
Today —
ci.ymlruns the whole suite onwindows-latestaswindows (non-required):continue-on-error: true, and not inrequired-green'sneeds. That is step 4 of #149 as written — non-required at first, then required — and this issue is the "then".The leg's first run on #279 was already green after the
#[cfg_attr(windows, ignore = "…")]pass (358 passed, 0 failed, 82 ignored on the dispatch workflow; the CI leg itself green onceenv_clear_blocks_inheritance…probedUSERPROFILEinstead ofHOME). What it has not yet shown is that it stays green: ConPTY behaviour on the runner image,cargo build -pof the fixtures from inside the tests on a Windows filesystem, and the two liveness paths #277 synthesizes fromtry_waitare all things a few weeks of PRs will exercise more honestly than one run did.Fix — two edits, written next to the job: drop
continue-on-error, addwindowstorequired-green'sneeds. Consider at the same time whetherwindows.yml's suite step is still worth keeping alongside the probe, now that the leg runs the suite on every PR.Done when — the leg has been green on every push to
mainfor a stretch long enough to trust (a release cycle is a natural one),required-greenneeds it, and CONTRIBUTING §1 still lists the one command it runs.