Skip to content

Commit 35458fb

Browse files
ThierryRakotomananaThierryRakotomanana
committed
refactor: removed extra space & unecessary loaders
1 parent 0fc6e9d commit 35458fb

2 files changed

Lines changed: 77 additions & 77 deletions

File tree

‎packages/create-webpack-app/templates/init/default/webpack.config.tpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const stylesHandler = isProduction ? MiniCssExtractPlugin.loader : "style-loader
2020
const stylesHandler = "style-loader";<% } %><% } %>
2121

2222
/** @type {import("webpack").Configuration} */
23-
const config <% if (langType === "Typescript") { %>: Configuration<% } %> = {
23+
const config <% if (langType === "Typescript") { %>: Configuration<% } %>= {
2424
entry: "<%= entryPoint %>",
2525
output: {
2626
path: path.resolve(__dirname, "dist"),

‎test/create-webpack-app/init/__snapshots__/init.test.js.snap.webpack5‎

Lines changed: 76 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ exports[`create-webpack-app cli recognizes '-t' as an alias for '--template' and
1313
},
1414
"name": "webpack-project",
1515
"scripts": {
16-
"build": "webpack --mode=production --config-node-env=production ",
17-
"build:dev": "webpack --mode=development ",
18-
"serve": "webpack serve ",
19-
"watch": "webpack --watch ",
16+
"build": "webpack --mode=production --config-node-env=production",
17+
"build:dev": "webpack --mode=development",
18+
"serve": "webpack serve",
19+
"watch": "webpack --watch",
2020
},
2121
"type": "module",
2222
"version": "1.0.0",
@@ -36,10 +36,10 @@ exports[`create-webpack-app cli should ask question when wrong template is suppl
3636
},
3737
"name": "webpack-project",
3838
"scripts": {
39-
"build": "webpack --mode=production --config-node-env=production ",
40-
"build:dev": "webpack --mode=development ",
41-
"serve": "webpack serve ",
42-
"watch": "webpack --watch ",
39+
"build": "webpack --mode=production --config-node-env=production",
40+
"build:dev": "webpack --mode=development",
41+
"serve": "webpack serve",
42+
"watch": "webpack --watch",
4343
},
4444
"type": "module",
4545
"version": "1.0.0",
@@ -56,10 +56,10 @@ exports[`create-webpack-app cli should configure WDS as opted 1`] = `
5656
},
5757
"name": "webpack-project",
5858
"scripts": {
59-
"build": "webpack --mode=production --config-node-env=production ",
60-
"build:dev": "webpack --mode=development ",
61-
"serve": "webpack serve ",
62-
"watch": "webpack --watch ",
59+
"build": "webpack --mode=production --config-node-env=production",
60+
"build:dev": "webpack --mode=development",
61+
"serve": "webpack serve",
62+
"watch": "webpack --watch",
6363
},
6464
"type": "module",
6565
"version": "1.0.0",
@@ -80,7 +80,7 @@ const isProduction = process.env.NODE_ENV === "production";
8080

8181

8282
/** @type {import("webpack").Configuration} */
83-
const config = {
83+
const config = {
8484
entry: "./src/index.js",
8585
output: {
8686
path: path.resolve(__dirname, "dist"),
@@ -130,9 +130,9 @@ exports[`create-webpack-app cli should configure html-webpack-plugin as opted 1`
130130
},
131131
"name": "webpack-project",
132132
"scripts": {
133-
"build": "webpack --mode=production --config-node-env=production ",
134-
"build:dev": "webpack --mode=development ",
135-
"watch": "webpack --watch ",
133+
"build": "webpack --mode=production --config-node-env=production",
134+
"build:dev": "webpack --mode=development",
135+
"watch": "webpack --watch",
136136
},
137137
"type": "module",
138138
"version": "1.0.0",
@@ -153,7 +153,7 @@ const isProduction = process.env.NODE_ENV === "production";
153153

154154

155155
/** @type {import("webpack").Configuration} */
156-
const config = {
156+
const config = {
157157
entry: "./src/index.js",
158158
output: {
159159
path: path.resolve(__dirname, "dist"),
@@ -209,9 +209,9 @@ exports[`create-webpack-app cli should configure workbox-webpack-plugin as opted
209209
},
210210
"name": "webpack-project",
211211
"scripts": {
212-
"build": "webpack --mode=production --config-node-env=production ",
213-
"build:dev": "webpack --mode=development ",
214-
"watch": "webpack --watch ",
212+
"build": "webpack --mode=production --config-node-env=production",
213+
"build:dev": "webpack --mode=development",
214+
"watch": "webpack --watch",
215215
},
216216
"type": "module",
217217
"version": "1.0.0",
@@ -233,7 +233,7 @@ const isProduction = process.env.NODE_ENV === "production";
233233

234234

235235
/** @type {import("webpack").Configuration} */
236-
const config = {
236+
const config = {
237237
entry: "./src/index.js",
238238
output: {
239239
path: path.resolve(__dirname, "dist"),
@@ -289,9 +289,9 @@ exports[`create-webpack-app cli should generate ES6 project correctly 1`] = `
289289
},
290290
"name": "webpack-project",
291291
"scripts": {
292-
"build": "webpack --mode=production --config-node-env=production ",
293-
"build:dev": "webpack --mode=development ",
294-
"watch": "webpack --watch ",
292+
"build": "webpack --mode=production --config-node-env=production",
293+
"build:dev": "webpack --mode=development",
294+
"watch": "webpack --watch",
295295
},
296296
"type": "module",
297297
"version": "1.0.0",
@@ -312,7 +312,7 @@ const isProduction = process.env.NODE_ENV === "production";
312312

313313

314314
/** @type {import("webpack").Configuration} */
315-
const config = {
315+
const config = {
316316
entry: "./src/index.js",
317317
output: {
318318
path: path.resolve(__dirname, "dist"),
@@ -365,10 +365,10 @@ exports[`create-webpack-app cli should generate default project when nothing is
365365
},
366366
"name": "webpack-project",
367367
"scripts": {
368-
"build": "webpack --mode=production --config-node-env=production ",
369-
"build:dev": "webpack --mode=development ",
370-
"serve": "webpack serve ",
371-
"watch": "webpack --watch ",
368+
"build": "webpack --mode=production --config-node-env=production",
369+
"build:dev": "webpack --mode=development",
370+
"serve": "webpack serve",
371+
"watch": "webpack --watch",
372372
},
373373
"type": "module",
374374
"version": "1.0.0",
@@ -390,7 +390,7 @@ const isProduction = process.env.NODE_ENV === "production";
390390

391391

392392
/** @type {import("webpack").Configuration} */
393-
const config = {
393+
const config = {
394394
entry: "./src/index.js",
395395
output: {
396396
path: path.resolve(__dirname, "dist"),
@@ -450,10 +450,10 @@ exports[`create-webpack-app cli should generate default project when nothing is
450450
},
451451
"name": "webpack-project",
452452
"scripts": {
453-
"build": "webpack --mode=production --config-node-env=production ",
454-
"build:dev": "webpack --mode=development ",
455-
"serve": "webpack serve ",
456-
"watch": "webpack --watch ",
453+
"build": "webpack --mode=production --config-node-env=production",
454+
"build:dev": "webpack --mode=development",
455+
"serve": "webpack serve",
456+
"watch": "webpack --watch",
457457
},
458458
"type": "module",
459459
"version": "1.0.0",
@@ -475,7 +475,7 @@ const isProduction = process.env.NODE_ENV === "production";
475475

476476

477477
/** @type {import("webpack").Configuration} */
478-
const config = {
478+
const config = {
479479
entry: "./src/index.js",
480480
output: {
481481
path: path.resolve(__dirname, "dist"),
@@ -534,9 +534,9 @@ exports[`create-webpack-app cli should generate default project when nothing is
534534
},
535535
"name": "webpack-project",
536536
"scripts": {
537-
"build": "webpack --mode=production --config-node-env=production ",
538-
"build:dev": "webpack --mode=development ",
539-
"watch": "webpack --watch ",
537+
"build": "webpack --mode=production --config-node-env=production",
538+
"build:dev": "webpack --mode=development",
539+
"watch": "webpack --watch",
540540
},
541541
"type": "module",
542542
"version": "1.0.0",
@@ -558,7 +558,7 @@ const isProduction = process.env.NODE_ENV === "production";
558558

559559

560560
/** @type {import("webpack").Configuration} */
561-
const config = {
561+
const config = {
562562
entry: "./src/index.js",
563563
output: {
564564
path: path.resolve(__dirname, "dist"),
@@ -618,10 +618,10 @@ exports[`create-webpack-app cli should generate default project when nothing is
618618
},
619619
"name": "webpack-project",
620620
"scripts": {
621-
"build": "webpack --mode=production --config-node-env=production ",
622-
"build:dev": "webpack --mode=development ",
623-
"serve": "webpack serve ",
624-
"watch": "webpack --watch ",
621+
"build": "webpack --mode=production --config-node-env=production",
622+
"build:dev": "webpack --mode=development",
623+
"serve": "webpack serve",
624+
"watch": "webpack --watch",
625625
},
626626
"type": "module",
627627
"version": "1.0.0",
@@ -643,7 +643,7 @@ const isProduction = process.env.NODE_ENV === "production";
643643

644644

645645
/** @type {import("webpack").Configuration} */
646-
const config = {
646+
const config = {
647647
entry: "./src/index.js",
648648
output: {
649649
path: path.resolve(__dirname, "dist"),
@@ -703,10 +703,10 @@ exports[`create-webpack-app cli should generate default project when nothing is
703703
},
704704
"name": "webpack-project",
705705
"scripts": {
706-
"build": "webpack --mode=production --config-node-env=production ",
707-
"build:dev": "webpack --mode=development ",
708-
"serve": "webpack serve ",
709-
"watch": "webpack --watch ",
706+
"build": "webpack --mode=production --config-node-env=production",
707+
"build:dev": "webpack --mode=development",
708+
"serve": "webpack serve",
709+
"watch": "webpack --watch",
710710
},
711711
"type": "module",
712712
"version": "1.0.0",
@@ -728,7 +728,7 @@ const isProduction = process.env.NODE_ENV === "production";
728728

729729

730730
/** @type {import("webpack").Configuration} */
731-
const config = {
731+
const config = {
732732
entry: "./src/index.js",
733733
output: {
734734
path: path.resolve(__dirname, "dist"),
@@ -788,10 +788,10 @@ exports[`create-webpack-app cli should generate folders if non existing generati
788788
},
789789
"name": "webpack-project",
790790
"scripts": {
791-
"build": "webpack --mode=production --config-node-env=production ",
792-
"build:dev": "webpack --mode=development ",
793-
"serve": "webpack serve ",
794-
"watch": "webpack --watch ",
791+
"build": "webpack --mode=production --config-node-env=production",
792+
"build:dev": "webpack --mode=development",
793+
"serve": "webpack serve",
794+
"watch": "webpack --watch",
795795
},
796796
"type": "module",
797797
"version": "1.0.0",
@@ -811,10 +811,10 @@ exports[`create-webpack-app cli should generate project when generationPath is s
811811
},
812812
"name": "webpack-project",
813813
"scripts": {
814-
"build": "webpack --mode=production --config-node-env=production ",
815-
"build:dev": "webpack --mode=development ",
816-
"serve": "webpack serve ",
817-
"watch": "webpack --watch ",
814+
"build": "webpack --mode=production --config-node-env=production",
815+
"build:dev": "webpack --mode=development",
816+
"serve": "webpack serve",
817+
"watch": "webpack --watch",
818818
},
819819
"type": "module",
820820
"version": "1.0.0",
@@ -1083,9 +1083,9 @@ exports[`create-webpack-app cli should generate typescript project correctly 1`]
10831083
},
10841084
"name": "webpack-project",
10851085
"scripts": {
1086-
"build": "NODE_OPTIONS='--loader ts-node/esm --no-warnings' webpack --mode=production --config-node-env=production -c ./webpack.config.ts",
1087-
"build:dev": "NODE_OPTIONS='--loader ts-node/esm --no-warnings' webpack --mode=development -c ./webpack.config.ts",
1088-
"watch": "NODE_OPTIONS='--loader ts-node/esm --no-warnings' webpack --watch -c ./webpack.config.ts",
1086+
"build": "webpack --mode=production --config-node-env=production",
1087+
"build:dev": "webpack --mode=development",
1088+
"watch": "webpack --watch",
10891089
},
10901090
"type": "module",
10911091
"version": "1.0.0",
@@ -1107,7 +1107,7 @@ const isProduction = process.env.NODE_ENV === "production";
11071107

11081108

11091109
/** @type {import("webpack").Configuration} */
1110-
const config : Configuration = {
1110+
const config : Configuration= {
11111111
entry: "./src/index.ts",
11121112
output: {
11131113
path: path.resolve(__dirname, "dist"),
@@ -1294,9 +1294,9 @@ exports[`create-webpack-app cli should use css preprocessor and css with postcss
12941294
},
12951295
"name": "webpack-project",
12961296
"scripts": {
1297-
"build": "webpack --mode=production --config-node-env=production ",
1298-
"build:dev": "webpack --mode=development ",
1299-
"watch": "webpack --watch ",
1297+
"build": "webpack --mode=production --config-node-env=production",
1298+
"build:dev": "webpack --mode=development",
1299+
"watch": "webpack --watch",
13001300
},
13011301
"type": "module",
13021302
"version": "1.0.0",
@@ -1321,7 +1321,7 @@ const stylesHandler = isProduction ? MiniCssExtractPlugin.loader : "style-loader
13211321

13221322

13231323
/** @type {import("webpack").Configuration} */
1324-
const config = {
1324+
const config = {
13251325
entry: "./src/index.js",
13261326
output: {
13271327
path: path.resolve(__dirname, "dist"),
@@ -1382,9 +1382,9 @@ exports[`create-webpack-app cli should use to use css preprocessor with postcss
13821382
},
13831383
"name": "webpack-project",
13841384
"scripts": {
1385-
"build": "webpack --mode=production --config-node-env=production ",
1386-
"build:dev": "webpack --mode=development ",
1387-
"watch": "webpack --watch ",
1385+
"build": "webpack --mode=production --config-node-env=production",
1386+
"build:dev": "webpack --mode=development",
1387+
"watch": "webpack --watch",
13881388
},
13891389
"type": "module",
13901390
"version": "1.0.0",
@@ -1409,7 +1409,7 @@ const stylesHandler = isProduction ? MiniCssExtractPlugin.loader : "style-loader
14091409

14101410

14111411
/** @type {import("webpack").Configuration} */
1412-
const config = {
1412+
const config = {
14131413
entry: "./src/index.js",
14141414
output: {
14151415
path: path.resolve(__dirname, "dist"),
@@ -1462,10 +1462,10 @@ exports[`create-webpack-app cli should work with 'new' alias 1`] = `
14621462
},
14631463
"name": "webpack-project",
14641464
"scripts": {
1465-
"build": "webpack --mode=production --config-node-env=production ",
1466-
"build:dev": "webpack --mode=development ",
1467-
"serve": "webpack serve ",
1468-
"watch": "webpack --watch ",
1465+
"build": "webpack --mode=production --config-node-env=production",
1466+
"build:dev": "webpack --mode=development",
1467+
"serve": "webpack serve",
1468+
"watch": "webpack --watch",
14691469
},
14701470
"type": "module",
14711471
"version": "1.0.0",
@@ -1481,9 +1481,9 @@ exports[`create-webpack-app cli uses yarn as the package manager when opted 1`]
14811481
},
14821482
"name": "webpack-project",
14831483
"scripts": {
1484-
"build": "webpack --mode=production --config-node-env=production ",
1485-
"build:dev": "webpack --mode=development ",
1486-
"watch": "webpack --watch ",
1484+
"build": "webpack --mode=production --config-node-env=production",
1485+
"build:dev": "webpack --mode=development",
1486+
"watch": "webpack --watch",
14871487
},
14881488
"type": "module",
14891489
"version": "1.0.0",

0 commit comments

Comments
 (0)