Fix #9

Author: bearloga

.Rbuildignore

@@ -6,3 +6,4 @@
 ^README.Rmd
 ^CONDUCT\.md$
 ^README_cache$
+^\.lintr$

.lintr

@@ -0,0 +1,5 @@
+linters: with_defaults(line_length_linter(120), object_usage_linter = NULL, closed_curly_linter = NULL, open_curly_linter = NULL, spaces_left_parentheses_linter = NULL, camel_case_linter = NULL)
+exclusions: list()
+exclude: "# Exclude Linting"
+exclude_start: "# Begin Exclude Linting"
+exclude_end: "# End Exclude Linting"

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: WikidataQueryServiceR
 Title: API Client Library for 'Wikidata Query Service'
-Version: 0.2.0.9000
-Date: 2017-04-28
+Version: 1.0.0
+Date: 2017-08-05
 Authors@R: c(
     person("Mikhail", "Popov", email = "mikhail@wikimedia.org",
            role = c("aut", "cre"), comment = "@bearloga on Twitter"),
@@ -16,6 +16,9 @@ Imports:
     dplyr (>= 0.5.0),
     jsonlite (>= 1.2),
     WikipediR (>= 1.5.0)
+Suggests:
+    testthat,
+    lintr
 URL: https://github.com/bearloga/WikidataQueryServiceR
 BugReports: https://github.com/bearloga/WikidataQueryServiceR/issues
 License: MIT + file LICENSE

R/wdqs.R

@@ -18,6 +18,8 @@
 #'   by Navino Evans
 #' - _[Learning SPARQL](http://www.learningsparql.com/)_ by Bob DuCharme
 #' - [WDQS User Manual](https://www.mediawiki.org/wiki/Wikidata_query_service/User_Manual)
+#' - [Quick intro to WDQS & SPARQL](https://github.com/bearloga/wmf/blob/master/presentations/talks/Cascadia\%20R\%20Conference\%202017/presentation.md#wikidata-query-service-wdqs)
+#'   from [my Cascadia R Conference 2017 talk](https://github.com/bearloga/wmf/tree/master/presentations/talks/Cascadia\%20R\%20Conference\%202017)
 #' @aliases WDQS
 #' @docType package
 #' @name WDQSR-package

man/WDQSR-package.Rd

@@ -0,0 +1,4 @@
+library(testthat)
+library(WikidataQueryServiceR)
+
+test_check("WikidataQueryServiceR")

tests/testthat.R

@@ -0,0 +1,31 @@
+context("Querying")
+
+query <- "SELECT DISTINCT
+  ?softwareVersion ?publicationDate
+WHERE {
+  BIND(wd:Q206904 AS ?R)
+  ?R p:P348 [
+    ps:P348 ?softwareVersion;
+    pq:P577 ?publicationDate
+  ] .
+}"
+
+suppressMessages({
+  simple_results <- query_wikidata(query, format = "simple")
+  smart_results <- query_wikidata(query, format = "smart")
+})
+
+test_that("data", {
+  expect_s3_class(simple_results, "data.frame")
+  expect_s3_class(smart_results, "data.frame")
+  expect_equal(names(simple_results), c("softwareVersion", "publicationDate"))
+  expect_equal(names(smart_results), c("softwareVersion", "publicationDate"))
+})
+
+test_that("date formatting", {
+  expect_s3_class(smart_results$publicationDate, "POSIXct")
+})
+
+test_that("simple ~= smart", {
+  expect_equal(nrow(simple_results), nrow(smart_results))
+})

tests/testthat/test-query.R

@@ -0,0 +1,6 @@
+if (requireNamespace("lintr", quietly = TRUE)) {
+  context("Lints")
+  test_that("package style", {
+    lintr::expect_lint_free()
+  })
+}