Merge pull request #3 from willysoft/test/dynamic-option-update

test: add dynamic option update handling in LocalPortFilteringMiddlew…

Author: willysoft

test/LocalPortFiltering.AspNetCore.Tests/LocalPortFiltering.AspNetCore.Tests.csproj

@@ -14,6 +14,10 @@
 
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="6.0.0" />
+    <PackageReference Include="coverlet.msbuild" Version="6.0.3">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="8.0.11" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageReference Include="Moq" Version="4.20.72" />

test/LocalPortFiltering.AspNetCore.Tests/LocalPortFilteringMiddlewareTests.cs

@@ -71,19 +71,24 @@ public async Task LocalPortFiltering_RejectsBlockedPort(int status, int localPor
     }
 
     [Theory]
-    [InlineData(true)]
-    [InlineData(false)]
-    public async Task LocalPortFiltering_Response(bool includeFailureMessage)
+    [InlineData(true, true)]
+    [InlineData(true, false)]
+    [InlineData(false, true)]
+    [InlineData(false, false)]
+    public async Task LocalPortFiltering_Response(bool initialIncludeFailureMessage, bool updatedIncludeFailureMessage)
     {
         // Arrange
+        Action<LocalPortFilteringOptions, string?>? onChangeCallback = null;
         var options = new LocalPortFilteringOptions()
         {
-            IncludeFailureMessage = includeFailureMessage
+            IncludeFailureMessage = initialIncludeFailureMessage
         };
         var optionsMonitor = new Mock<IOptionsMonitor<LocalPortFilteringOptions>>();
         optionsMonitor.Setup(o => o.CurrentValue)
                       .Returns(options)
                       .Verifiable();
+        optionsMonitor.Setup(o => o.OnChange(It.IsAny<Action<LocalPortFilteringOptions, string?>>()))
+                      .Callback<Action<LocalPortFilteringOptions, string?>>(callback => onChangeCallback = callback);
         var middleware = new LocalPortFilteringMiddleware(Mock.Of<RequestDelegate>(), optionsMonitor.Object);
 
         var httpContext = new DefaultHttpContext();
@@ -93,13 +98,17 @@ public async Task LocalPortFiltering_Response(bool includeFailureMessage)
         httpContext.Response.Body = responseBody;
 
         // Act
+        onChangeCallback?.Invoke(new LocalPortFilteringOptions
+        {
+            IncludeFailureMessage = updatedIncludeFailureMessage
+        }, "TestChange");
         await middleware.Invoke(httpContext);
         responseBody.Seek(0, SeekOrigin.Begin);
         var responseContent = responseBody.ToArray();
 
         // Assert
         Assert.Equal(403, httpContext.Response.StatusCode);
-        if (includeFailureMessage)
+        if (updatedIncludeFailureMessage)
         {
             Assert.Equal(LocalPortFilteringMiddleware.DefaultResponse.Length, httpContext.Response.ContentLength);
             Assert.Equal("application/json", httpContext.Response.ContentType);