test: Add test case for IncludeFailureMessage in Response handling

Author: willysoft

src/LocalPortFiltering.AspNetCore/LocalPortFiltering.AspNetCore.csproj

@@ -33,4 +33,8 @@
     <None Include="..\..\LICENSE" Pack="true" PackagePath=""/>
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="LocalPortFiltering.AspNetCore.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100f5f2a2ae57a4ea4e4d38024fcb6522b42690b4354163433d56f4037839e752e66fbe6ebf7b44d7e9b52e53f8e463b5d92225805e77dbd9632d627908bcac7d2bb1827db14242de07271e3423346a467336840c0593c8a9c79826d767d34185830c6a0ba925f9f79799dcbe1d9c4b25d93679e22199bf0f00052a4ca9758b6dc7" />
+  </ItemGroup>
+
 </Project>

src/LocalPortFiltering.AspNetCore/LocalPortFilteringMiddleware.cs

@@ -11,7 +11,7 @@ namespace LocalPortFiltering.AspNetCore;
 public class LocalPortFilteringMiddleware
 {
     // Matches Http.Sys.
-    private static readonly byte[] DefaultResponse = Encoding.ASCII.GetBytes(
+    internal static readonly byte[] DefaultResponse = Encoding.ASCII.GetBytes(
             "{\"message\":\"Access to the requested port is not allowed.\"}"
     );
 
@@ -69,5 +69,4 @@ private Task HostValidationFailed(HttpContext context)
         }
         return Task.CompletedTask;
     }
-
 }

test/LocalPortFiltering.AspNetCore.Tests/LocalPortFiltering.AspNetCore.Tests.csproj

@@ -7,6 +7,9 @@
 
     <IsPackable>false</IsPackable>
     <IsTestProject>true</IsTestProject>
+
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>..\..\src\LocalPortFiltering.AspNetCore\opensource.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
   <ItemGroup>

…eringConventionBuilderExtensionsTests.cs …pointConventionBuilderExtensionsTests.cstest/LocalPortFiltering.AspNetCore.Tests/LocalPortFilteringConventionBuilderExtensionsTests.cs renamed to test/LocalPortFiltering.AspNetCore.Tests/LocalPortFilteringEndpointConventionBuilderExtensionsTests.cs test/LocalPortFiltering.AspNetCore.Tests/LocalPortFilteringConventionBuilderExtensionsTests.cs renamed to test/LocalPortFiltering.AspNetCore.Tests/LocalPortFilteringEndpointConventionBuilderExtensionsTests.cs

@@ -2,10 +2,10 @@
 using Microsoft.AspNetCore.Http;
 
 namespace LocalPortFiltering.AspNetCore.Tests;
-public class LocalPortFilteringConventionBuilderExtensionsTests
+public class LocalPortFilteringEndpointConventionBuilderExtensionsTests
 {
     [Fact]
-    public void RequireLocalPort_AllowPort_MetadataAdded()
+    public void RequireLocalPort_AllowPorts_MetadataAdded()
     {
         // Arrange
         var testConventionBuilder = new TestEndpointConventionBuilder();

test/LocalPortFiltering.AspNetCore.Tests/LocalPortFilteringMiddlewareTests.cs

@@ -13,7 +13,7 @@ namespace LocalPortFiltering.AspNetCore.Tests;
 public class LocalPortFilteringMiddlewareTests
 {
     [Fact]
-    public async Task TestLocalPortFiltering_DefaultBehavior()
+    public async Task LocalPortFiltering_DefaultBehavior()
     {
         // Arrange
         using var host = new HostBuilder()
@@ -48,7 +48,7 @@ public async Task TestLocalPortFiltering_DefaultBehavior()
     [InlineData(403, 4000, new int[] { 3000, 3001 })]
     [InlineData(200, 1005, new int[] { 1000, 1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010 })]
     [InlineData(403, 1500, new int[] { 1000, 1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010 })]
-    public async Task TestLocalPortFiltering_RejectsBlockedPort(int status, int localPort, int[] allowPort)
+    public async Task LocalPortFiltering_RejectsBlockedPort(int status, int localPort, int[] allowPort)
     {
         // Arrange
         var options = new LocalPortFilteringOptions();
@@ -68,4 +68,46 @@ public async Task TestLocalPortFiltering_RejectsBlockedPort(int status, int loca
         // Assert
         Assert.Equal(status, (int)httpContext.Response.StatusCode);
     }
+
+    [Theory]
+    [InlineData(true)]
+    [InlineData(false)]
+    public async Task LocalPortFiltering_Response(bool includeFailureMessage)
+    {
+        // Arrange
+        var options = new LocalPortFilteringOptions()
+        {
+            IncludeFailureMessage = includeFailureMessage
+        };
+        var optionsMonitor = new Mock<IOptionsMonitor<LocalPortFilteringOptions>>();
+        optionsMonitor.Setup(o => o.CurrentValue)
+                      .Returns(options)
+                      .Verifiable();
+        var middleware = new LocalPortFilteringMiddleware(Mock.Of<RequestDelegate>(), optionsMonitor.Object);
+
+        var httpContext = new DefaultHttpContext();
+        httpContext.SetEndpoint(new Endpoint(c => Task.CompletedTask, new EndpointMetadataCollection(new LocalPortFilteringAttribute(80)), "Test endpoint"));
+        httpContext.Connection.LocalPort = 443;
+        using var responseBody = new MemoryStream();
+        httpContext.Response.Body = responseBody;
+
+        // Act
+        await middleware.Invoke(httpContext);
+        responseBody.Seek(0, SeekOrigin.Begin);
+        var responseContent = responseBody.ToArray();
+
+        // Assert
+        Assert.Equal(403, httpContext.Response.StatusCode);
+        if (includeFailureMessage)
+        {
+            Assert.Equal(LocalPortFilteringMiddleware.DefaultResponse.Length, httpContext.Response.ContentLength);
+            Assert.Equal("application/json", httpContext.Response.ContentType);
+            Assert.Equal(LocalPortFilteringMiddleware.DefaultResponse, responseContent);
+        }
+        else
+        {
+            Assert.Null(httpContext.Response.ContentLength);
+            Assert.Empty(responseContent);
+        }
+    }
 }