Remove Id setter from ValueObjectDocument.

Author: iscottb122

src/Winton.DomainModelling.DocumentDb/ValueObjectDocument.cs

@@ -9,18 +9,25 @@ namespace Winton.DomainModelling.DocumentDb
     internal sealed class ValueObjectDocument<TValueObject>
         where TValueObject : struct, IEquatable<TValueObject>
     {
-        public ValueObjectDocument(TValueObject valueObject)
+        [JsonConstructor]
+        private ValueObjectDocument(TValueObject valueObject, string id)
         {
             ValueObject = valueObject;
+            Id = id;
         }
 
         [JsonProperty(PropertyName = "id")]
-        public string Id { get; set; }
+        public string Id { get; }
 
         public string Type => GetDocumentType();
 
         public TValueObject ValueObject { get; }
 
+        public static ValueObjectDocument<TValueObject> Create(TValueObject valueObject)
+        {
+            return new ValueObjectDocument<TValueObject>(valueObject, null);
+        }
+
         public static string GetDocumentType()
         {
             return typeof(TValueObject).Name;

src/Winton.DomainModelling.DocumentDb/ValueObjectFacade.cs

@@ -61,7 +61,7 @@ public async Task Create<TValueObject>(TValueObject valueObject)
 
             if (document == null)
             {
-                document = new ValueObjectDocument<TValueObject>(valueObject);
+                document = ValueObjectDocument<TValueObject>.Create(valueObject);
 
                 await _documentClient.CreateDocumentAsync(GetUri(), document);
             }

test/Winton.DomainModelling.DocumentDb.Tests/ValueObjectDocumentTests.cs

@@ -58,24 +58,13 @@ public sealed class Id : ValueObjectDocumentTests
             private void ShouldDefaultToNull()
             {
                 var valueObject = new TestValueObject("A");
-                var document = new ValueObjectDocument<TestValueObject>(valueObject);
+                ValueObjectDocument<TestValueObject> document = ValueObjectDocument<TestValueObject>.Create(valueObject);
 
                 string id = document.Id;
 
                 id.Should().BeNull();
             }
 
-            [Fact]
-            private void ShouldReturnSetId()
-            {
-                var valueObject = new TestValueObject("A");
-                var document = new ValueObjectDocument<TestValueObject>(valueObject) { Id = "1" };
-
-                string id = document.Id;
-
-                id.Should().Be("1");
-            }
-
             [Fact]
             private void ShouldSerializePropertyNameAsLowercase()
             {
@@ -91,7 +80,7 @@ public sealed class Type : EntityDocumentTests
             private void ShouldReturnEntityType()
             {
                 var valueObject = new TestValueObject("A");
-                var document = new ValueObjectDocument<TestValueObject>(valueObject);
+                ValueObjectDocument<TestValueObject> document = ValueObjectDocument<TestValueObject>.Create(valueObject);
 
                 string type = document.Type;
 
@@ -105,7 +94,7 @@ public sealed class ValueObject : ValueObjectDocumentTests
             private void ShouldReturnValueObject()
             {
                 var expected = new TestValueObject("A");
-                var document = new ValueObjectDocument<TestValueObject>(expected);
+                ValueObjectDocument<TestValueObject> document = ValueObjectDocument<TestValueObject>.Create(expected);
 
                 TestValueObject valueObject = document.ValueObject;