Fix bug with JsonPrimitiveVisitor not respecting the culture of JsonSerializer. (#51)

Author: Choc13

src/Winton.Extensions.Configuration.Consul/Parsers/Json/JsonPrimitiveVisitor.cs

@@ -33,7 +33,7 @@ private ICollection<KeyValuePair<string, string>> VisitPrimitive(JToken primitiv
             string key = ConfigurationPath.Combine(_context.Reverse());
             return new[]
             {
-                new KeyValuePair<string, string>(key, primitive.ToString())
+                new KeyValuePair<string, string>(key, primitive.Value<string>())
             };
         }
 

test/Winton.Extensions.Configuration.Consul.Test/Parsers/Json/JsonPrimitiveVisitorTests.cs

@@ -1,4 +1,6 @@
 using System.Collections.Generic;
+using System.Globalization;
+using System.Threading;
 using FluentAssertions;
 using Newtonsoft.Json.Linq;
 using Xunit;
@@ -77,6 +79,29 @@ public sealed class VisitJObject : JsonPrimitiveVisitorTests
                 }
             };
 
+            [Fact]
+            private void ShouldConvertPrimitivesToStringUsingJsonSerializerCulture()
+            {
+                CultureInfo originalCuluture = Thread.CurrentThread.CurrentCulture;
+                Thread.CurrentThread.CurrentCulture = new CultureInfo("de-DE");
+
+                try
+                {
+                    IEnumerable<KeyValuePair<string, string>> primitives =
+                        _visitor.VisitJObject(new JObject(new JProperty("Test", new JValue(1.5))));
+
+                    primitives.Should().BeEquivalentTo(
+                        new List<KeyValuePair<string, string>>
+                        {
+                            new KeyValuePair<string, string>("Test", "1.5")
+                        });
+                }
+                finally
+                {
+                    Thread.CurrentThread.CurrentCulture = originalCuluture;
+                }
+            }
+
             [Theory]
             [MemberData(nameof(TestCases))]
             private void ShouldVisitAllPrimitivesInJObject(