Roborio cross compiling toolchain does not work with bzlmod

[pjreiniger]

Locally on my laptop

PS C:\Users\PJ\git\wpilibsuite\allwpilib> bazel build //wpiutil/...  -j 1 -s                                                                            
INFO: Invocation ID: e51a3ed4-7f2b-4383-ab77-15855680f4e2
INFO: Streaming build results to: https://app.buildbuddy.io/invocation/e51a3ed4-7f2b-4383-ab77-15855680f4e2
INFO: Analyzed 36 targets (0 packages loaded, 0 targets configured).
SUBCOMMAND: # //thirdparty/googletest:googletest [action 'Compiling thirdparty/googletest/src/googlemock/src/gmock-cardinalities.cpp', configuration: 99695a78787e1b38c8452f3ece91eb96b7338eb51a21c023bcd8e0d566250c78, execution platform: @@platforms//host:host, mnemonic: CppCompile]
cd /d C:/users/pj/_bazel_pj/t6alavnl/execroot/_main
  SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\WINDOWS;C:\WINDOWS\System32;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\Users\PJ\AppData\Local\bazelisk\downloads\bazelbuild\bazel-7.2.0-windows-x86_64\bin;C:\Users\Public\wpilib\2024\jdk\bin;C:\Program Files\National Instruments\Shared\OpenVINO\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\ProgramData\chocolatey\bin;C:\Users\PJ\AppData\Local\Programs\Python\Python310;C:\msys64\usr\bin;C:\Program Files\Go\bin;C:\Program Files\GitHub CLI\;C:\Program Files\nodejs\;C:\ProgramData\nvm;C:\Program Files\nodejs;C:\Program Files\PuTTY\;C:\Program Files\dotnet\;C:\Users\PJ\.cargo\bin;C:\Users\PJ\scoop\shims;C:\Users\PJ\AppData\Local\Microsoft\WindowsApps;C:\Users\PJ\AppData\Local\JetBrains\Toolbox\scripts;C:\Users\PJ\go\bin;C:\Users\PJ\AppData\Local\Microsoft\WindowsApps;C:\Users\PJ\AppData\Roaming\npm;C:\Program Files\CMake\bin
    SET PWD=/proc/self/cwd
    SET RUNFILES_MANIFEST_ONLY=1
  external\rules_bzlmodrio_toolchains~~sh_configure~local_roborio\bin\gcc.bat @bazel-out/x64_windows-fastbuild-roborio/bin/thirdparty/googletest/_objs/googletest/gmock-cardinalities.o.params
# Configuration: 99695a78787e1b38c8452f3ece91eb96b7338eb51a21c023bcd8e0d566250c78
# Execution platform: @@platforms//host:host
ERROR: C:/users/pj/git/wpilibsuite/allwpilib/thirdparty/googletest/BUILD.bazel:3:18: Compiling thirdparty/googletest/src/googlemock/src/gmock-cardinalities.cpp failed: (Exit 1): gcc.bat failed: error executing CppCompile command (from target //thirdparty/googletest:googletest) external\rules_bzlmodrio_toolchains~~sh_configure~local_roborio\bin\gcc.bat @bazel-out/x64_windows-fastbuild-roborio/bin/thirdparty/googletest/_objs/googletest/gmock-cardinalities.o.params
arm-frc2024-linux-gnueabi-gcc.exe: fatal error: cannot execute 'as': CreateProcess: No such file or directory
compilation terminated.
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1.713s, Critical Path: 1.06s                                                                                                        
INFO: 2 processes: 2 internal.                                                                                                                          
ERROR: Build did NOT complete successfully                 

On github actions:

ERROR: D:/a/allwpilib/allwpilib/wpiutil/examples/writelog/BUILD.bazel:3:17: Compiling wpiutil/examples/writelog/writelog.cpp failed: (Exit 1): gcc.bat failed: error executing CppCompile command (from target //wpiutil/examples/writelog:writelog) 
  cd /d C:/bazelroot/vbgseepj/execroot/_main
  SET PATH=C:\Program Files\Git\usr\bin;C:\Program Files\Git\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Users\runneradmin\AppData\Local\bazelisk\downloads\sha256\3141dc703f9f7126cb91fd459429b8452bc7b82857504e23cf929600ef5b36d8\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\runneradmin\bin;C:\hostedtoolcache\windows\Java_Zulu_jdk\17.0.12-7\x64\bin;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\3.1.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\mingw64\bin;C:\Program Files\dotnet;C:\Program Files\MySQL\MySQL Server 8.0\bin;C:\Program Files\R\R-4.4.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\SeleniumWebDrivers\ChromeDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\usr\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.21.13\x64\bin;C:
    SET ***
    SET RUNFILES_MANIFEST_ONLY=1
  external\rules_bzlmodrio_toolchains~~sh_configure~local_roborio\bin\gcc.bat @bazel-out/x64_windows-fastbuild-roborio/bin/wpiutil/examples/writelog/_objs/writelog/writelog.o.params
# Configuration: 877e495a9e2698d41c015f00727730e4d0338350ac153862ef7e035f33d866b6
# Execution platform: @@platforms//host:host
Assembler messages:
Fatal error: invalid -march= option: `armv7-a+mp+sec+simd'

[AustinSchuh]

Awesome, thanks. To reproduce, I just need need to checkout your allwpilib repo in bzlmodRio, latest version?

[pjreiniger]

Yeah that should definitely fail, at least on ci. I left it out of my comment, but I had --config=windows --enable_bzlmod in my user.rc.

I'm pretty sure it would fail with a bare bones hello world program too.

[AustinSchuh]

Agreed, this looks non-wpilib specific, and like a toolchain configuration problem.

[Gold856]

Root caused to the toolchain path being just over 260 characters. That causes GCC to try invoking as instead of the absolute path to as.exe, which fails because it's not on PATH.

[AustinSchuh]

The other improvement would be:

s/sh_configure/cfg/g
s/local_bookworm_32/bookworm32/g

etc. I'm not sure the extra characters are helping with clarity.

Any reason not to call this wpilib_toolchains too? That's another 9 characters. And at this point is as descriptive.

[AustinSchuh]

#36 implements most of that. I left the local_ prefix.