Skip to content

Build error #97

@guimard

Description

@guimard

Hello,
I fixed compilation using this:

--- a/node-stringprep.cc
+++ b/node-stringprep.cc
@@ -194,7 +194,7 @@
   if (info.Length() >= 2 && info[0]->IsString() && info[1]->IsInt32())
   {
     String::Value str(info[0]->ToString());
-    int32_t options = info[1]->ToInt32()->Value();
+    int32_t options = Nan::To<int32_t>(info[1]).FromJust();
     UErrorCode error = U_ZERO_ERROR;
     UIDNA *uidna = uidna_openUTS46(options, &error);
     if (U_FAILURE(error))
@@ -252,7 +252,7 @@
   if (info.Length() >= 2 && info[0]->IsString() && info[1]->IsInt32())
   {
     String::Value str(info[0]->ToString());
-    int32_t options = info[1]->ToInt32()->Value();
+    int32_t options = Nan::To<int32_t>(info[1]).FromJust();
     UErrorCode error = U_ZERO_ERROR;
     UIDNA *uidna = uidna_openUTS46(options, &error);
     if (U_FAILURE(error))

Cheers,
Xavier

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions