Deprecated DSA host keys

Author: zeroSal-le

src/Adapter/Ssh/SshAdapter.php

@@ -32,7 +32,6 @@ public function __construct()
             '-o', 'ControlMaster=auto',
             '-o', 'ControlPath=/tmp/php-seven-ssh-%C',
             '-o', 'ControlPersist=60m',
-            '-o', 'HostKeyAlgorithms=+ssh-dss',
             '-o', 'StrictHostKeyChecking=no',
             '-o', 'UserKnownHostsFile=/dev/null',
         ];
@@ -274,4 +273,21 @@ public function addIdentityFile(string $path): self
 
         return $this;
     }
+
+    public function permitDsaHostKey(bool $status): self
+    {
+        $this->options = array_values(array_filter(
+            $this->options,
+            fn ($opt) => 'HostKeyAlgorithms=+ssh-dss' !== $opt
+        ));
+
+        if ($status) {
+            $this->options = array_merge(
+                $this->options,
+                ['-o', 'HostKeyAlgorithms=+ssh-dss']
+            );
+        }
+
+        return $this;
+    }
 }

tests/Adapter/Ssh/SshAdapterTest.php

@@ -19,4 +19,20 @@ public function testSetters()
         $this->assertEquals(30, $adapter->getTimeout());
         $this->assertContains('-o', $adapter->getOptions());
     }
+
+    public function testPermitDsaHostKey()
+    {
+        $adapter = new SshAdapter();
+        $options = $adapter->getOptions();
+
+        $this->assertNotContains('HostKeyAlgorithms=+ssh-dss', $options);
+
+        $adapter->permitDsaHostKey(true);
+        $options = $adapter->getOptions();
+        $this->assertContains('HostKeyAlgorithms=+ssh-dss', $options);
+
+        $adapter->permitDsaHostKey(false);
+        $options = $adapter->getOptions();
+        $this->assertNotContains('HostKeyAlgorithms=+ssh-dss', $options);
+    }
 }