Reject trailing bytes in block proof payloads - #2459
Draft
quby1845 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockProofencodingMotivation
Deserializable::read_from_bytesintentionally permits trailing input. In the proof writer thismeans a canonical
BlockProoffollowed by arbitrary bytes can pass deserialization and the entirepayload can then be persisted and re-broadcast.
This change makes decoding exact: it parses a proof within the supplied payload budget and verifies
that the reader is exhausted before the proof is accepted.
Scope
This is an interim hardening change, not cryptographic block-proof verification.
BlockProofiscurrently a placeholder in
miden-protocol, and the protocol does not yet expose the proof data,public inputs, prover output, and verifier API required to implement the full fix described in
#2383. The existing verification TODO remains, with that dependency documented in the code.
Testing
BlockProofencodings are acceptedRefs #2383.