fix(store): reject oversized nullifier sync pages - #2462
Open
UfukNode wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select_nullifiers_by_prefixused to drop the truncation block when a response exceededMAX_ROWS. If every returned row came from that same block, it returned an empty page with a cursor before the block, so clients could keep asking for the same range forever.This now returns an explicit payload-limit error for that case, matching the transaction sync behavior. Added a regression test that inserts
MAX_ROWS + 1matching nullifiers in one block.Closes #2460.
Changelog