Skip to content

fix(store): reject oversized nullifier sync pages - #2462

Open
UfukNode wants to merge 1 commit into
0xMiden:nextfrom
UfukNode:fix-nullifier-page-limit
Open

fix(store): reject oversized nullifier sync pages#2462
UfukNode wants to merge 1 commit into
0xMiden:nextfrom
UfukNode:fix-nullifier-page-limit

Conversation

@UfukNode

@UfukNode UfukNode commented Aug 9, 2026

Copy link
Copy Markdown

Summary

select_nullifiers_by_prefix used to drop the truncation block when a response exceeded MAX_ROWS. If every returned row came from that same block, it returned an empty page with a cursor before the block, so clients could keep asking for the same range forever.

This now returns an explicit payload-limit error for that case, matching the transaction sync behavior. Added a regression test that inserts MAX_ROWS + 1 matching nullifiers in one block.

Closes #2460.

Changelog

[[entry]]
scope       = "rpc"
impact      = "fixed"
description = "Return an explicit error instead of stalling nullifier sync when one block exceeds the response payload limit."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

store: select_nullifiers_by_prefix stalls sync when single block exceeds MAX_ROWS for a prefix set

1 participant