Skip to content

fix(web-client): reject unrecognized auth components in getPublicKeyCommitments - #285

Open
igamigo wants to merge 1 commit into
nextfrom
igamigo-pubkey-commitments-strict
Open

fix(web-client): reject unrecognized auth components in getPublicKeyCommitments#285
igamigo wants to merge 1 commit into
nextfrom
igamigo-pubkey-commitments-strict

Conversation

@igamigo

@igamigo igamigo commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Account.getPublicKeyCommitments() returns [] for any account whose auth component isn't one of the bundled standard templates.

miden-standards classifies components by exact MAST-root containment, so a third-party auth component (e.g. OpenZeppelin Guardian's openzeppelin::auth::multisig_ecdsa) is bucketed as Custom, no auth component is detected, and the key read yields nothing. [] is indistinguishable from "keyless account", so the failure surfaces far from its cause — in the Miden wallet it became dApp connections failing with NOT_GRANTED (OpenZeppelin/guardian#306).

On miden-standards 0.16.0-alpha.4 it's worse than an empty list: AccountInterface::new asserts auth_count == 1, so these accounts panic across the WASM boundary. That also hits isFaucet() / isRegularAccount(), which route through the same AccountInterface::from_account.

@igamigo
igamigo force-pushed the igamigo-pubkey-commitments-strict branch from 534e6be to 7f95026 Compare August 12, 2026 15:41
@igamigo
igamigo force-pushed the igamigo-pubkey-commitments-strict branch from 7f95026 to 17b32bc Compare August 14, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant