fix(web-client): reject unrecognized auth components in getPublicKeyCommitments - #285
Open
igamigo wants to merge 1 commit into
Open
fix(web-client): reject unrecognized auth components in getPublicKeyCommitments#285igamigo wants to merge 1 commit into
igamigo wants to merge 1 commit into
Conversation
igamigo
force-pushed
the
igamigo-pubkey-commitments-strict
branch
from
August 12, 2026 15:41
534e6be to
7f95026
Compare
igamigo
force-pushed
the
igamigo-pubkey-commitments-strict
branch
from
August 14, 2026 03:43
7f95026 to
17b32bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account.getPublicKeyCommitments()returns[]for any account whose auth component isn't one of the bundled standard templates.miden-standardsclassifies components by exact MAST-root containment, so a third-party auth component (e.g. OpenZeppelin Guardian'sopenzeppelin::auth::multisig_ecdsa) is bucketed asCustom, no auth component is detected, and the key read yields nothing.[]is indistinguishable from "keyless account", so the failure surfaces far from its cause — in the Miden wallet it became dApp connections failing withNOT_GRANTED(OpenZeppelin/guardian#306).On
miden-standards0.16.0-alpha.4it's worse than an empty list:AccountInterface::newassertsauth_count == 1, so these accounts panic across the WASM boundary. That also hitsisFaucet()/isRegularAccount(), which route through the sameAccountInterface::from_account.