Add opt-in encoder-decoder framework modules - #551
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the reusable encoder-decoder framework additions onto current main, without bringing in model implementations or registrations.
Compatibility and Scope
Existing defaults remain unchanged: GELU activation, non-materialized GLU gates, and the existing cross-attention path. Existing keep-mask, attention-prior, and attention-output APIs are retained; the flash path is a separate explicit API.
Includes focused framework unit coverage for defaults, opt-ins, stage masks, affine binding, cached decoder composition, and flash-mask contracts.
Only framework headers/sources and their unit tests are included. No model code, model specs, UI, weights, build registration, or ggml changes. The Qwen prefill/cache additions already merged into main are excluded.