Use the makePool method in tests#31
Open
rustaceanrob wants to merge 2 commits into
Open
Conversation
I think most clients will opt for this simpler interface so I converted all tests to use the pool rather than the proxy thread.
rustaceanrob
force-pushed
the
impl-make-pool
branch
from
July 10, 2026 10:38
0d644b9 to
ffb504f
Compare
Sjors
reviewed
Jul 10, 2026
| .await; | ||
| } | ||
|
|
||
| /// Exercise the older `context.thread` dispatch path: instead of relying on |
Collaborator
There was a problem hiding this comment.
In stead of just "older", maybe elaborate on situations where this approach is preferred (if any).
Ensure older client versions still work without the thread pool.
rustaceanrob
force-pushed
the
impl-make-pool
branch
from
July 13, 2026 12:09
ffb504f to
9f8785d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30