Check all fields of *zbstore.ObjectInfo in VerifyObject - #352
Merged
Conversation
Verification frequently occurs during ingest, so added an optional argument to tee the NAR to a destination writer. This unconvered a defect in `internal/backend.TestDelete`: one of the objects imported during setup did not contain a valid self-reference. The verification step (correctly) ignored the object. Yay for more robust input validation! Object content is also verified to be a valid NAR file. Updates 256lights#345 Fixes 256lights#66
zombiezen
force-pushed
the
push-lzvqzosknlnn
branch
from
August 21, 2026 03:52
b5f4a51 to
a43f570
Compare
zombiezen
marked this pull request as ready for review
August 21, 2026 03:52
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification frequently occurs during ingest, so added an optional argument to tee the NAR to a destination writer.
This unconvered a defect in
internal/backend.TestDelete: one of the objects imported during setup did not contain a valid self-reference. The verification step (correctly) ignored the object. Yay for more robust input validation!Object content is also verified to be a valid NAR file.
Updates #345
Fixes #66
Related Pull Requests
This pull request is part of a stack managed by jj-domino:
internal/backend.verifyContentAddress#359*zbstore.Derivation.SHA256RealizationHashto return errors #360