Fix/#480 공통여정 답변 상세보기에서 뒤로 가기 클릭 시 공통 여정 탭으로 이동하도록 수정#481
Open
dev-domo wants to merge 2 commits into
Open
Conversation
1 task
Walkthrough유효한 탭을 클릭하면 화면 전환 전에 Changes탭 선택 상태 동기화
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
juri123123
approved these changes
Jul 27, 2026
Comment on lines
28
to
+45
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(true) | ||
| tabBarController?.tabBar.isHidden = false | ||
|
|
||
| guard controllers.indices.contains(selectedIndex) else { return } | ||
|
|
||
| show(controllers[selectedIndex]) | ||
| tabBar.select(index: selectedIndex) | ||
| } | ||
|
|
||
| override func viewWillDisappear(_ animated: Bool) { | ||
| super.viewWillDisappear(animated) | ||
|
|
||
| if navigationController?.topViewController === self { | ||
| selectedIndex = 0 | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
요거 viewDidLoad 뒤로 갈 수 있도록 수정 부탁드립니다 ! 실행 순서대로 함수가 나열되어 있어야 가독성이 올라갈 것 같아요 ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
✅ Testing
공통 여정 답변 상세보기에서 뒤로 가기 클릭
공통 여정 관련 알림을 탭하여 -> 공통 여정 답변 상세보기로 이동한 후 -> 뒤로 가기를 클릭한다.
홈에서 퀘스트 탭을 클릭하고 -> 공통 여정 탭바를 클릭한 후 -> 공통 여정 답변 상세보기로 이동한 후 -> 뒤로 가기를 클릭한다.
공통 여정 답변 상세보기에서 뒤로 가기 클릭 시 공통 여정 탭으로 이동한다.
💻 주요 코드 설명
ParentQuestViewController