vms-ddc: SHOW DEVICE/FULL renders the full block in the bare listing - #1060
Open
baron-3dl wants to merge 1 commit into
Open
vms-ddc: SHOW DEVICE/FULL renders the full block in the bare listing#1060baron-3dl wants to merge 1 commit into
baron-3dl wants to merge 1 commit into
Conversation
Operator direct-test: `SHOW DEVICE/FULL` "does nothing". Root cause: in cmd_show_device()'s bare-listing path, the terminal loop called the brief show_device_row() regardless of /FULL -- only the disk loop and the NAMED device path honored it. So a bare `SHOW DEVICE/FULL` on a terminal-only view printed the same one-line rows as bare `SHOW DEVICE`. Fixed: the bare terminal loop now renders show_device_terminal_full() under /FULL, mirroring the disk loop and the named path. Not fabrication -- SHOW DEVICE reads the real executive device table via /dev/vms; this is a qualifier that was parsed but not applied in one code path. PROVEN: dcl_acceptance_battery.sh now exercises BARE `SHOW DEVICE/FULL` and asserts the console's full block (Terminal OPA0: + Owner process) appears -- the surface the gate never covered. Confirmed PASS on the Alpha DCL/SHOW acceptance leg (workflow_dispatch run 34149477870). OPA0: exists on every arch, so the assertion is substrate-independent. The separate SHOW DEVICE VDA0:->NOSUCHDEV symptom (non-virtio disks never probed on bare metal) is a distinct fix that needs a non-virtio guest disk to prove; it is split to its own branch (vms-ddc / vms-47d) rather than ship probe code whose positive proof does not yet land. Refs vms-ddc, vms-050 (oracle-driven UX-fidelity). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018q4jvj6GCkdbYjRvpy7Vwu
baron-3dl
force-pushed
the
work/vms-ddc-showdevice-faithful
branch
from
September 7, 2026 18:11
9102593 to
673b274
Compare
baron-3dl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator evidence
SHOW DEVICE/FULL"does nothing".Root cause (not fabrication)
SHOW DEVICE reads the real executive device table via
/dev/vms. But incmd_show_device()'s bare-listing path, the terminal loop called the briefshow_device_row()regardless of/FULL— only the disk loop and the named device path honored it. So bareSHOW DEVICE/FULLon a terminal-only view printed the same one-line rows as bareSHOW DEVICE: a qualifier parsed but not applied in one code path.Fix
The bare terminal loop now renders
show_device_terminal_full()under/FULL, mirroring the disk loop and the named path.Proven
dcl_acceptance_battery.shnow exercises bareSHOW DEVICE/FULLand asserts the console full block (Terminal OPA0:+Owner process) appears — the surface the gate never covered. Confirmed PASS on the Alpha DCL/SHOW acceptance leg (workflow_dispatch run 34149477870). Substrate-independent (OPA0: exists on every arch).Scope note
The separate
SHOW DEVICE VDA0:→NOSUCHDEV symptom (non-virtio disks never probed on bare metal) is a distinct fix split to its own branch — its executive-probe code is correct (proven INV-6-honest: enters nothing when no node exists), but the positive proof needs a non-virtio disk enumerable in the guest kernel, which needs guest-kernel work. Not shipping probe code whose positive proof doesn't yet land (anti-LARP). Tracked under vms-ddc / vms-47d.🤖 Generated with Claude Code