Skip to content

fix: 'getColContentSize' for single row with 0 as value#1222

Merged
6pac merged 2 commits into
6pac:masterfrom
muendlein:fix-content-size-with-single-0
Jun 14, 2026
Merged

fix: 'getColContentSize' for single row with 0 as value#1222
6pac merged 2 commits into
6pac:masterfrom
muendlein:fix-content-size-with-single-0

Conversation

@muendlein

Copy link
Copy Markdown
Contributor

Fixes #1221

Note: I have also added an early return in case of no rows at all.

@muendlein muendlein changed the title Fix 'getColContentSize' for single row with 0 as value fix 'getColContentSize' for single row with 0 as value Jun 13, 2026
@muendlein muendlein changed the title fix 'getColContentSize' for single row with 0 as value fix: 'getColContentSize' for single row with 0 as value Jun 13, 2026
@6pac

6pac commented Jun 14, 2026

Copy link
Copy Markdown
Owner

All good by me. @ghiscoding ?

@ghiscoding

Copy link
Copy Markdown
Collaborator

@6pac that's your column resize functions, it seems fine by me, I'll let you deal with this one...

@6pac

6pac commented Jun 14, 2026

Copy link
Copy Markdown
Owner

sure mate, thanks, just like to run everything by you. Maybe will stop bugging you about this small stuff.

@6pac 6pac merged commit dc17328 into 6pac:master Jun 14, 2026
3 of 5 checks passed
@ghiscoding

ghiscoding commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

haha it's all good, no worries 😉

@6pac also if you want to push a new release, just do these steps shown below, in this case a patch release would be correct since it's a bug fix (a new feature would typically be a minor release) and click on the green button "Run Workflow" which is behind the dropdown. I'll let you do this one by yourself so that you know how to do it (only you and I can push new releases) 😃

image

@6pac

6pac commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Cool. If you're not desperate for a release @muendlein I'll wait a few days and make that other patch as well.

@muendlein

Copy link
Copy Markdown
Contributor Author

@6pac No worries, this can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getColContentSize yielding wrong outcome with single 0 row

3 participants