Skip to content

fix: proxy genai service for swagger for kubernetes deployment - #99

Merged
JonathanPschl merged 2 commits into
mainfrom
feature/final_fixes
Jul 16, 2026
Merged

fix: proxy genai service for swagger for kubernetes deployment#99
JonathanPschl merged 2 commits into
mainfrom
feature/final_fixes

Conversation

@timn21

@timn21 timn21 commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • API gateway configuration now supports displaying the GenAI service’s OpenAPI specification in Swagger UI.
  • Performance

    • Adjusted CPU allocation limits across application, database, and monitoring services to improve resource efficiency.
  • Documentation

    • Updated infrastructure documentation with the current remote state storage configuration.
  • Infrastructure

    • Refreshed infrastructure provider verification data and backend settings for reliable deployments.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Helm CPU limits are reduced for application, database, and monitoring containers, and the API gateway gains a GenAI service URL. Terraform AzureRM backend settings and documentation change, with updated provider lockfile checksums.

Changes

Helm configuration

Layer / File(s) Summary
Helm resources and gateway wiring
helm/bytebite/templates/*, helm/bytebite/values.yaml
CPU limits are reduced across application, database, and monitoring workloads. The API gateway receives GENAI_SERVICE_BASE_URL using the configured GenAI service port.

Terraform configuration

Layer / File(s) Summary
Terraform backend and provider lockfile
infra/terraform/versions.tf, infra/terraform/README.md, infra/terraform/.terraform.lock.hcl
AzureRM backend resource and storage settings, their documentation, and three provider checksum entries are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: maliklesch

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the API gateway change to proxy the GenAI service into Swagger UI, even though the PR also includes resource and Terraform updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/final_fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@infra/terraform/versions.tf`:
- Around line 20-21: Update the Terraform backend initialization workflow
associated with resource_group_name and storage_account_name to explicitly
migrate existing state when switching backend coordinates, using -migrate-state
rather than silently adopting the new location. Verify the first plan is a
no-op; use -reconfigure only when a separate state is intentionally required.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a16cf8ef-4b74-4590-8590-8fca92240e6c

📥 Commits

Reviewing files that changed from the base of the PR and between 4680466 and 6c255af.

📒 Files selected for processing (11)
  • helm/bytebite/templates/api-gateway-deployment.yaml
  • helm/bytebite/templates/client-deployment.yaml
  • helm/bytebite/templates/genai-deployment.yaml
  • helm/bytebite/templates/grocery-db-deployment.yaml
  • helm/bytebite/templates/grocery-service-deployment.yaml
  • helm/bytebite/templates/user-db-deployment.yaml
  • helm/bytebite/templates/user-service-deployment.yaml
  • helm/bytebite/values.yaml
  • infra/terraform/.terraform.lock.hcl
  • infra/terraform/README.md
  • infra/terraform/versions.tf

Comment on lines +20 to +21
resource_group_name = "terraform_bytebite"
storage_account_name = "bytebitetim"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail
rg -n -C 3 'terraform init|resource_group_name|storage_account_name|container_name' \
  .github/workflows infra/terraform

Repository: AET-DevOps26/team-bytebite

Length of output: 5223


Migrate the Terraform state before switching backend coordinates. terraform init -input=false will point CI at a new state location; if that backend is empty, apply can run against fresh state and recreate existing infrastructure. Use -migrate-state for an intentional move, or -reconfigure only if a separate state is intended, and make sure the first plan is a no-op.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@infra/terraform/versions.tf` around lines 20 - 21, Update the Terraform
backend initialization workflow associated with resource_group_name and
storage_account_name to explicitly migrate existing state when switching backend
coordinates, using -migrate-state rather than silently adopting the new
location. Verify the first plan is a no-op; use -reconfigure only when a
separate state is intentionally required.

@JonathanPschl JonathanPschl left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JonathanPschl
JonathanPschl merged commit 190db57 into main Jul 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants