[Qwen3.5] Onboard model to Checkpointing Util & Verify Correctness#3839
Open
Rohan-Bierneni wants to merge 2 commits intomainfrom
Open
[Qwen3.5] Onboard model to Checkpointing Util & Verify Correctness#3839Rohan-Bierneni wants to merge 2 commits intomainfrom
Rohan-Bierneni wants to merge 2 commits intomainfrom
Conversation
Add config file for 397B model update attentions.py with new decoder block type Update other files with new model to ensure model initialization is correct Update decoder block type Train Compile test is passing resolve nits in config file formatting resolve formatting errors Fix conflict in maxtext_utils Fix linter errors Fix linter errors Fix linter errors Ran pyink locally for formatting Fix naming for config file Add code for param_mapping for qwen3.5 Add hook fn function for Qwen3.5 Update hook logic for 1 to n mt -> hf hook fns
Rohan-Bierneni
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR onboard the Qwen3.5 model to the checkpointing util. Also we now use the converted hf -> maxtext checkpoint to run forward_pass_logit checker and verify model correctness.
Tests
Results of forward_pass_logit_checker:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.