Fix argument and resource type injection in gke_utils.py#228
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Fix argument and resource type injection in gke_utils.py#228copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_911651432
branch
2 times, most recently
from
83c24c7 to
023e764
Compare
- Added strict validation for Kubernetes resource names to prevent injection of flags or alternate resource types. - Updated kubectl commands to use the '--' delimiter to separate flags from positional arguments. - Prefixed pod names with 'pod/' in kubectl commands to be explicit. - Updated unit tests in gke_utils_test.py to cover new validation and command formats. - Fixed broken test in isc_pathways_test.py due to command format change. - Fixed broken test in gke_utils_test.py regarding fetch_cluster_credentials. PiperOrigin-RevId: 911651432
copybara-service
Bot
force-pushed
the
test_911651432
branch
from
023e764 to
adc6f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix argument and resource type injection in gke_utils.py