This repository was archived by the owner on Apr 17, 2026. It is now read-only.
add test for maestro commands - #27
Merged
Merged
Conversation
akihikokuroda
marked this pull request as draft
October 31, 2025 17:31
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
akihikokuroda
marked this pull request as ready for review
October 31, 2025 18:15
akihikokuroda
requested review from
AngeloDanducci,
ajbozarth,
george-lhj,
maximilien,
planetf1 and
psschwei
October 31, 2025 18:15
george-lhj
reviewed
Oct 31, 2025
There was a problem hiding this comment.
I saw that there are a few tests that look either like duplicates or very similar, for example inside tests/integration/agent, customreousrce, etc, to the tests that are newly added.
Should those be consolidated, removed, etc. Should that be in this PR as well? Or followup?
Member
Author
|
Thanks for review. I'll do it in a follow up PR. Bob told me to keep both but I'll check them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add test following maestro commands
fix #25