Skip to content

Deprecate the usage of -> instead of . for objects that are not pointers #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmadlener merged 2 commits into from
Aug 11, 2025
Merged

Deprecate the usage of -> instead of . for objects that are not pointers #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af47537
Deprecate operator-> for objects that are not pointers
jmcarcell Jul 29, 2025
d1afda4
Fix the deprecation warning in podio
jmcarcell Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/templates/Collection.h.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public:
void print(std::ostream& os=std::cout, bool flush=true) const final;

/// operator to allow pointer like calling of members a la LCIO
[[deprecated("Use of operator->() is deprecated. Use . instead.")]]
{{ class.bare_type }}Collection* operator->() { return static_cast<{{ class.bare_type }}Collection*>(this); }

/// Append a new object to the collection, and return this object.
Expand Down
4 changes: 2 additions & 2 deletions tests/unittests/frame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,10 +398,10 @@ TEST_CASE("Frame destructor ASanFail") {
auto& hitClusters = hitClusterMap[name];

for (int i = 0; i < 3; ++i) {
auto cluster = hitClusters.first->create();
auto cluster = hitClusters.first.create();

for (int j = 0; j < 5; ++j) {
auto hit = hitClusters.second->create();
auto hit = hitClusters.second.create();
cluster.addHits(hit);
}
}
Expand Down