fix: use parameterized Popen[bytes] for QEMU handle type annotation in guest_vsock.py

[Copilot]

The process parameter in wait_for_guest and check_guest_ready was annotated as subprocess.Popen | None, dropping the bytes type argument and diverging from the rest of the codebase (e.g. VMLaunchResult.process: subprocess.Popen[bytes] | None).

Change

• sev_verify/guest_vsock.py — Updated both occurrences to subprocess.Popen[bytes] | None:

# Before
process: subprocess.Popen | None = None

# After
process: subprocess.Popen[bytes] | None = None

Applies to wait_for_guest (line 146) and check_guest_ready (line 184).

[Copilot]

Copilot wasn't able to review any files in this pull request.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

sev_verify/vm_profile.py:234

• The PR title/description state this is only a type-annotation fix in guest_vsock.py, but this hunk introduces functional behavior changes (passing the QEMU process into guest readiness checks and altering failure messaging/diagnostics). Please update the PR title/description to reflect the expanded scope (or split the behavioral changes into a separate PR) so reviewers and release notes aren’t misled.

            # Passing the process lets the wait abort as soon as QEMU dies,
            # instead of polling vsock until the boot timeout expires against
            # a VM that no longer exists.
            booted, boot_error = check_guest_ready(self, process=process)

sev_verify/vm_profile.py:244

• Reading QEMU stderr via _read_guest_errors() loads the entire log file into memory (Path.read_bytes()) and only then truncates to max_bytes. If QEMU emits a large stderr log, this can cause avoidable memory spikes and slow failure handling. Consider changing _read_guest_errors() to read only the tail (seek from end) instead of reading the whole file.

                    stderr_tail = _read_guest_errors(self.guest_error_log).strip()
                    if stderr_tail:
                        message = f"{message}\nQEMU stderr:\n{stderr_tail}"