Visualiser: PKCE login on plain-http deployments#686
Merged
Conversation
crypto.subtle only exists in secure contexts, and several ACS deployments serve the visualiser over plain http (kiosk displays on closed networks especially), where login died before redirecting. Fall back to a pure-JS FIPS 180-4 SHA-256 for the PKCE challenge; verified byte-for-byte against node:crypto across block boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On http-only clusters (e.g. FPD/ago)
crypto.subtleis undefined (secure contexts only), so the OIDC login introduced in #685 threwCannot read properties of undefined (reading 'digest')instart_code_flowbefore ever redirecting to Keycloak.Add a pure-JS SHA-256 fallback for the PKCE code challenge, used only when
crypto.subtleis absent. The implementation is fuzz-tested byte-for-byte againstnode:crypto(516 vectors including block-boundary lengths).How to test
crypto.subtlepath).🤖 Generated with Claude Code