Merge schwarzschild metric files into development - #128
Open
cellio00 wants to merge 29 commits into
Open
Conversation
…d of interpolate_rhs_from_mesh to use Metric.H
…ack to the previous prescription.
srichers
self-requested a review
June 24, 2026 15:03
srichers
requested changes
Jun 24, 2026
srichers
left a comment
srichers
left a comment
Collaborator
There was a problem hiding this comment.
Before reviewing further, it would be good to have a relativistic test problem implemented.
I will be trying to get Debraj's metric branch pulled in so the merge diff should be smaller soon.
…tolerance is not great (passes for 1e-3)
…apse*p^t) to integrate over coordinate time. Verified that phi is changing in the orbit.
cellio00
changed the title
Collaborator
Author
|
Removing draft status and requesting re-review from Sherwood, review from Debraj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the Schwarzschild metric header file and the photon ring test implementation to verify that, in the simplified case of a photon moving at r=3M, theta=pi/2, that the energy and angular momentum in the z direction are conserved.
The photon ring test passes for tolerance < 1e-12, and ensures that the photon at least makes one orbit around the black hole.
No implementation has been integrated into Emu yet until review of this PR.