Add Rosenbrock-2S method#1994
Draft
BenWibking wants to merge 6 commits into
Draft
Conversation
Collaborator
Author
|
@zingale Here's the draft PR. This does not have all the performance optimizations that I tried. |
Collaborator
Author
|
This version wins by a few percent on CPU [Mac laptop] over VODE for primordial_chem when building both with Clang (which is much faster than gcc on CPU for these problems). The performance delta is significantly larger on a Hopper GPU (in favor of Rosenbrock). |
Member
|
this gets an FPE if I build and run |
Member
|
it seems to be that it is generating really negative mass fractions and that's causing the failure, so we probably need more step rejection logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
ROS2Sintegrator from https://doi.org/10.1016/j.apnum.2012.08.001.It is a three-stage, second-order, stiffly-accurate, L-stable Rosenbrock-Wanner method with an embedded error estimator.