Skip to content

fix issues 85 89 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asalmgren merged 1 commit into from
Aug 23, 2026
Merged

fix issues 85 89 #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Source/CAMR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,13 +1312,17 @@ CAMR::ZeroingOutForPlotting(amrex::MultiFab& S)
amrex::ParallelFor(bx, [=] AMREX_GPU_DEVICE(int i, int j, int k) noexcept {
if (vfrac_arr(i,j,k) == 0.0)
{
for (int n = 0; n < ncomp; ++n) {
Sarr(i, j, k, n) = 0.0;
for (int n = 0; n < ncomp; ++n) {
Sarr(i, j, k, n) = 0.0;
}
}
{
}
else
{
// Clean up denormal-scale noise only. Note that we must test the
// magnitude here -- a signed test would zero every legitimately
// negative value, e.g. all negative momenta and velocities.
for (int n = 0; n < ncomp; ++n) {
if(Sarr(i, j, k, n) < 1e-12){
if (amrex::Math::abs(Sarr(i, j, k, n)) < 1.e-12) {
Sarr(i, j, k, n) = 0.0;
}
}
Expand Down
7 changes: 6 additions & 1 deletion Source/Utils/CAMR_reset_internal_e.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,16 @@ CAMR_reset_internal_e(
S(i, j, k, UEDEN) = S(i,j,k,UEINT) + rho * ke;

} else if (S(i,j,k,UEINT) <= 0.) {
// Note that we must take the delta against the (rho e) from
// before the floor is applied, so we hold on to it rather than
// relying on the order of the two writes below.
const amrex::Real rhoe_old = S(i, j, k, UEINT);

EOS::RTY2E(rho,small_T,massfrac,e_out);
S(i, j, k, UEINT) = rho * e_out;

if (l_dual_energy_update_E_from_e == 1) {
S(i, j, k, UEDEN) += (rho * e_out - S(i,j,k,UEINT));
S(i, j, k, UEDEN) += (rho * e_out - rhoe_old);
}
}
}
Expand Down
Loading