Re-enable row_mt=1 combos in AVxEncoderThreadTestLarge - #5121
Open
dsummer wants to merge 1 commit into
Open
Conversation
These rows were disabled pending issue AOMediaCodec#79, which is fixed and closed. All 16 row_mt=1 combos (cpu-used {0,1,3,5} x tile cols/rows {1,6}) pass on current main, including encode/decode MD5 and frame-size checks across 2, 4, and 64 threads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uqub6MtkVTYS2t5ZGcRU92
Contributor
|
@dsummer : thanks for your first contribution here! Pls sign individual / corporate CLA (contributor licence agreement) : https://aomedia.org/about/legal/ to clear the CLA bot check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
row_mt=1rows ofAVxEncoderThreadTestLargewere disabled with a TODO referencing issue #79, which has since been fixed and closed.Verified on current
main(7802259): with::testing::Values(0, 1)restored, all 16row_mt=1combos (cpu-used {0, 1, 3, 5} x tile cols/rows {1, 6}) pass, including encode/decode MD5 and frame-size checks across 2, 4, and 64 threads (64-core Threadripper, gcc-15 Release build).This restores nightly coverage of the encoder row-MT path's thread-count invariance, which currently has none; see also the verification notes posted on issue #11.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Uqub6MtkVTYS2t5ZGcRU92