Skip to content

Add frame level on/off bawp #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jianle973 wants to merge 2 commits into
base: av2-enc
Choose a base branch
from
Open

Add frame level on/off bawp #5156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9763f48
Add frame level on/off bawp
jianle973 Jul 24, 2026
9a7e4ae
Address Yeqing's review
jianle973 Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions av2/encoder/encodeframe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1952,6 +1952,73 @@ static AVM_INLINE void av2_enc_setup_tip_frame(AV2_COMP *cpi) {
}
}

static void get_histogram(int32_t *hist, const YV12_BUFFER_CONFIG *buf,
int width, int height) {
uint16_t *y_buf = buf->y_buffer;
int stride = buf->y_stride;
for (int i = 0; i < height; i++) {
for (int j = 0; j < width; j++) {
hist[y_buf[j]]++;
}
y_buf += stride;
}
}

static int av2_set_on_bawp_picture_level(AV2_COMP *const cpi) {
int enable_curr_pic_bawp = 0;
assert(cpi->sf.inter_sf.enable_fast_bawp == 1);
AV2_COMMON *const cm = &cpi->common;
const YV12_BUFFER_CONFIG *source = cpi->source;

const int num_values = 1 << cm->seq_params.bit_depth;

int32_t *curr_hist;
int32_t *ref_hist;
CHECK_MEM_ERROR(cm, curr_hist, avm_calloc(num_values, sizeof(int32_t)));
CHECK_MEM_ERROR(cm, ref_hist, avm_calloc(num_values, sizeof(int32_t)));

const int width = source->y_width;
const int height = source->y_height;
const int num_samples = width * height;

//----- get histogram diff threshold -----
const double sample_thres =
cm->features.allow_screen_content_tools ? 0.0875 : 0.1125;
const int32_t hist_diff_thres = (int32_t)(sample_thres * num_samples);

// get histogram of the current picture
get_histogram(curr_hist, source, width, height);

for (MV_REFERENCE_FRAME rf = 0; rf < cm->ref_frames_info.num_total_refs;
++rf) {
const RefCntBuffer *ref_buf = get_ref_frame_buf(cm, rf);
if (ref_buf != NULL) {
int ref_width = ref_buf->mi_cols * MI_SIZE;
int ref_height = ref_buf->mi_rows * MI_SIZE;

if (width == ref_width && height == ref_height) {
memset(ref_hist, 0, sizeof(int32_t) * num_values);
// get histogram of the reference picture
get_histogram(ref_hist, &ref_buf->buf, width, height);

// get SAD of delta histogram
int32_t diff_hist = 0;
for (int i = 0; i < num_values; i++) {
diff_hist += abs(curr_hist[i] - ref_hist[i]);
}

if (diff_hist > hist_diff_thres) {
enable_curr_pic_bawp = 1;

@yeqing-wu yeqing-wu Jul 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once if (diffHist > hist_diff_thres) is satisfied, should we return here directly, to save the cost of the further histogram computation and checks? Based on the logic, in any case where diffHist > hist_diff_thres, enable_curr_pic_bawp would always be true, right? If yes, then we do not need enable_curr_pic_bawp

@jianle973 jianle973 Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should return immediately once (diffHist > hist_diff_thres) meets. In the code, this logic is fulfilled by

    if (diff_hist > hist_diff_thres) {
      enable_curr_pic_bawp = 1;
      **break;**
    }

break;
}
}
}
}
avm_free(curr_hist);
avm_free(ref_hist);
return enable_curr_pic_bawp;
}

/*!\brief Set the lossless flags for a frame before encoding it
*
* \ingroup high_level_algo
Expand Down Expand Up @@ -2229,6 +2296,10 @@ static AVM_INLINE void encode_frame_internal(AV2_COMP *cpi) {
start_timing(cpi, av2_compute_global_motion_time);
#endif
av2_compute_global_motion_facade(cpi);

if (features->enable_bawp && cpi->sf.inter_sf.enable_fast_bawp)
features->enable_bawp = av2_set_on_bawp_picture_level(cpi);

#if CONFIG_COLLECT_COMPONENT_TIMING
end_timing(cpi, av2_compute_global_motion_time);
#endif
Expand Down
2 changes: 2 additions & 0 deletions av2/encoder/speed_features.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ static void set_good_speed_features_framesize_independent(
sf->tx_sf.adaptive_tcq_threshold_qidx = 185;
sf->inter_sf.enable_enhanced_inter_mode_cache_reuse = 1;
sf->inter_sf.skip_temporary_pred_for_opfl = 1;
sf->inter_sf.enable_fast_bawp = 1;

// Enable the optimized inter-SDP fast method (requires >=1 intra coded
// block, prunes when inter-mode ratio exceeds 50%, and early skips when
Expand Down Expand Up @@ -794,6 +795,7 @@ static AVM_INLINE void init_inter_sf(INTER_MODE_SPEED_FEATURES *inter_sf) {
inter_sf->reuse_erp_mode_flag = 0;
inter_sf->prune_warpmv_prob_thresh = 32;
inter_sf->enable_enhanced_inter_mode_cache_reuse = 0;
inter_sf->enable_fast_bawp = 0;
}

static AVM_INLINE void init_interp_sf(INTERP_FILTER_SPEED_FEATURES *interp_sf) {
Expand Down
5 changes: 5 additions & 0 deletions av2/encoder/speed_features.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,11 @@ typedef struct INTER_MODE_SPEED_FEATURES {
// 0: original cache reuse logic.
// 1: enhanced cache reuse logic (more modes are searched).
int enable_enhanced_inter_mode_cache_reuse;

// Histogram based frame level on/off decision for BAWP
// 0: no frame level on/off decision
// 1: enable histogram based frame level on/off
int enable_fast_bawp;
} INTER_MODE_SPEED_FEATURES;

typedef struct INTERP_FILTER_SPEED_FEATURES {
Expand Down
Loading