Prune uneven 4A/4B partitions with neighbor block boundaries - #5193
Prune uneven 4A/4B partitions with neighbor block boundaries#5193urvangjoshi wants to merge 7 commits into
Conversation
b2d1f56 to
1e4439d
Compare
|
The trade off for class A2 is pretty good, however the trade off for class A1 is worse than the threshold. Currently, our rule is to make sure the trade off for both class A1 and A2 should satisfy the threshold. So, is it possible to add the qp dependent condition for this speed feature? For example, only turn on this speed feature for 4K sequence when qp is greater than one threshold? @urvangjoshi |
Thanks @leolzhao for the suggestion! Let me try some variations in this direction. |
|
Github uses markdown style in its conversation messages. To make sure that the results are not messed up by Github, please add ``` before and after the results. |
1e4439d to
b879167
Compare
@leolzhao : I made some tweaks to the code as follows:
With that, all sets seem to have a good trade-off now. See the updated commit message for latest results. |
b879167 to
92734ee
Compare
|
@leolzhao : I'm not sure why the CI run is failing in "common variable setup" phase. Seems to be a transient issue perhaps. |
Use the best partitioning boundaries of left / above coding blocks to prune uneven 4way partitions -- by checking boundary alignment. Only prune for inter frames. Enabled for speed >= 1. Results for RA CTC 33 frames, speed 1: (Anchor: aa78cfb) +---------+--------+--------+--------+--------+----------+ | Summary | Y | U | V | YUV | Enc-time | +---------+--------+--------+--------+--------+----------+ | A1 | 0.10% | 0.03% | 0.06% | 0.10% | 97.88% | | A2 | 0.07% | 0.08% | 0.13% | 0.07% | 95.50% | |avg wo b2| 0.07% | 0.12% | 0.07% | 0.07% | 95.23% | +---------+--------+--------+--------+--------+----------+ Note: no changes at speed 4, because uneven 4way partitions seem to be disabled / restricted at this speed. Related: refactor a common av2_get_chroma_start_location() function. STATS_CHANGED for speed >= 1.
92734ee to
b9fbdac
Compare
Use the best partitioning boundaries of left / above coding blocks to prune uneven 4way partitions -- by checking boundary alignment.
Only prune for inter frames.
Results for RA CTC 33 frames, speed 1:
(Anchor: 8d95884)
Note: no changes at speed 4, because uneven 4way partitions are disabled at this speed.
Related: refactor a common av2_get_chroma_start_location() function.
STATS_CHANGED for speed >= 1.