Fix encoder test-decode failure when S-frames are enabled - #5210
Open
xinzhao-apple wants to merge 1 commit into
Open
Fix encoder test-decode failure when S-frames are enabled#5210xinzhao-apple wants to merge 1 commit into
xinzhao-apple wants to merge 1 commit into
Conversation
With --enable-sframe=1, the encoder aborts during test decoding with "Failed to get decoder reference frame". Frames reaching the implicit-output suppression are hidden altrefs, so implicit output is their only route to being output, and gating it on enable_sframe cleared it while overlays still used show_existing_frame and emitted zero bytes, leaving nothing to output those display orders. The suppression is only needed when the overlay is fully coded instead, which happens only in global error resilient mode, so gate on g_error_resilient_mode alone at both sites. That mode already had enable_sframe 0, so its output is bit-identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --enable-sframe=1, the encoder aborts during test decoding with "Failed to get decoder reference frame". Frames reaching the implicit-output suppression are hidden altrefs, so implicit output is their only route to being output, and gating it on enable_sframe cleared it while overlays still used show_existing_frame and emitted zero bytes, leaving nothing to output those display orders.
The suppression is only needed when the overlay is fully coded instead, which happens only in global error resilient mode, so gate on g_error_resilient_mode alone at both sites. That mode already had enable_sframe 0, so its output is bit-identical.
Fixes issue #5209.