Refactor write_tile_info_max_tile - #5221
Merged
Merged
Conversation
This PR ports the read_tile_params() changes in PR AOMediaCodec#5187 to the encoder side. write_tile_info_max_tile() does not need to recalculate width_sb and height_sb. They are equal to tiles->sb_cols and tiles->sb_rows, respectively. See av2_get_tile_limits(). Rename write_tile_info_max_tile() to write_tile_params(). Replace write_tile_syntax_info() by write_tile_params().
wantehchang
commented
Aug 6, 2026
y-guyon
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the read_tile_params() changes in PR #5187 to the encoder side.
write_tile_info_max_tile() does not need to recalculate width_sb and height_sb. They are equal to tiles->sb_cols and tiles->sb_rows, respectively. See av2_get_tile_limits().
Rename write_tile_info_max_tile() to write_tile_params().
Replace write_tile_syntax_info() by write_tile_params().