Have write_tile_params() call avm_internal_error() - #5225
Open
wantehchang wants to merge 1 commit into
Open
Conversation
Need to pass `struct avm_internal_error_info *error_info` from the callers to write_tile_params(). Also need to change one top-level caller, av2_get_global_headers(), to call setjmp().
jzern
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to pass
struct avm_internal_error_info *error_infofrom the callers to write_tile_params(). Also need to change one top-level caller, av2_get_global_headers(), to call setjmp().