set_params_rd_pick_inter_mode: Remove dead code. - #5230
Open
urvangjoshi wants to merge 1 commit into
Open
Conversation
urvangjoshi
force-pushed
the
dead_prune_code_cleanup
branch
from
August 7, 2026 20:33
e8a103f to
fd57c39
Compare
This function is only called through the call chain: pick_sb_modes() --> av2_rd_pick_inter_mode_sb() --> set_params_rd_pick_inter_mode(). In this call chain, `mbmi->partition` is always set to `PARTITION_NONE`. So, the 2 set of code snippets were dead code.
urvangjoshi
force-pushed
the
dead_prune_code_cleanup
branch
from
August 7, 2026 23:18
fd57c39 to
e044c61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is only called through the call chain: pick_sb_modes() -->
av2_rd_pick_inter_mode_sb() --> set_params_rd_pick_inter_mode().
In this call chain,
mbmi->partitionis always set toPARTITION_NONE.So, the 2 set of code snippets were dead code.