Zero-init partition candidate stack arrays#619
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
find_best_partition_candidates()function can use uninitialized data in theuncor_best_partitionsandsamec_best_partitionsarrays as an index if most partition candidates fail to give a good result. Specifically, if fewer thanrequested_candidatesresult in an error that is lower thanERROR_CALC_DEFAULT, the tail of the array will not be initialized.This is expected to be very unlikely in real use, where the data is a real texture and a large number of possible partition candidates are used, but it's possible if using a very restricted partition set with random texture data.
Fixes #618.