Update proposal detail activity timeline to log owner-weight-change events (#397) - #561
Open
ByteForce-Labs wants to merge 1 commit into
Open
Conversation
|
@web3nova is attempting to deploy a commit to the thegreatfeez's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Resolve the conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #397
When an owner's voting weight changes, that event is now logged in the proposal detail page's activity timeline, interleaved in correct chronological order with existing approve, revoke, and execute events.
Changes
frontend/src/lib/contract.ts—getProposalEventsnow includes governance-wideowner_weight_changed(c_wgt) events in every proposal's chronological history, and each weight-change entry names the affected owner with its old → new weight (e.g.GOWNER...AAAA: Weight: 25 → 40).frontend/src/pages/ProposalDetailPage.tsx— activity timeline renders owner-weight-change entries with a clear "Owner Weight Changed" badge.frontend/src/lib/__tests__/contract-events.test.ts— updated to assert the owner-named weight-change detail.frontend/src/pages/ProposalDetailPage.test.tsx— added timeline rendering test for owner-weight-change events alongside approve/execute.getOwnerWeightreturnsbigint, recurring-proposal wrapper cleanup) andOwnersPagequorum/weight UI additions.Acceptance criteria