Reset default install folder for PyImath to include/Imath#508
Merged
cary-ilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Aug 13, 2025
Merged
Reset default install folder for PyImath to include/Imath#508cary-ilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
cary-ilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
The default inadvertently changed to include/PyImath in the v3.2 release. The significant change here to properly set the default for `PYIMATH_OUTPUT_SUBDIR` and use it in `src/python/PyImath/CMakeLists.txt`. The changes in the install manifests simply correct the mistaken install locations. Note that the 'custom namespace' job specifies a specific value of the subdir, to validate that the setting gets properly overridden. Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
added a commit
that referenced
this pull request
Aug 13, 2025
The default inadvertently changed to include/PyImath in the v3.2 release. The significant change here to properly set the default for `PYIMATH_OUTPUT_SUBDIR` and use it in `src/python/PyImath/CMakeLists.txt`. The changes in the install manifests simply correct the mistaken install locations. Note that the 'custom namespace' job specifies a specific value of the subdir, to validate that the setting gets properly overridden. Signed-off-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default inadvertently changed to include/PyImath in the v3.2 release.
The significant change here to properly set the default for
PYIMATH_OUTPUT_SUBDIRand use it insrc/python/PyImath/CMakeLists.txt.The changes in the install manifests simply correct the mistaken install locations. Note that the 'custom namespace' job specifies a specific value of the subdir, to validate that the setting gets properly overridden.