Remove duplicate ImathConfig ALIAS in cmake config#517
Remove duplicate ImathConfig ALIAS in cmake config#517cary-ilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
A duplicate add_library(Imath::Config ALIAS ImathConfig) line slipped in. Only newer CMake versions seem to catch this. Signed-off-by: Cary Phillips <cary@ilm.com>
lgritz
left a comment
lgritz
left a comment
There was a problem hiding this comment.
I don't totally understand the problems it causes, or if removing it will make anything behaviorally better, but there's no doubt that this line is literally redundant (see line 17) so I think it's definitely correct to remove it.
|
This is similar to the recent problem with OpenEXRConfig, IexConfig, and IlmThreadConfig, raised in AcademySoftwareFoundation/openexr#1817 and fixed in AcademySoftwareFoundation/openexr#2087. The error message didn't give much of a hint of what's actually wrong, unfortunately. CMake 3.30+ treats the duplicate OpenEXR CI jobs are failing now, but only when doing the FetchContent of Imath. I think the version of cmake the runner is picking up got bumped. |
A duplicate add_library(Imath::Config ALIAS ImathConfig) line slipped in. Only newer CMake versions seem to catch this. Signed-off-by: Cary Phillips <cary@ilm.com>
2 participants
A duplicate
add_library(Imath::Config ALIAS ImathConfig)line slipped in. The other is on line 17. Older CMake versions seem to ignore this but cmake 4 seems to report it as an error in certain circumstances.