Skip to content

Silence C++23 deprecation warning for numeric_limits<half>::has_denorm #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cary-ilm wants to merge 1 commit into from
+19 −1
Closed

Silence C++23 deprecation warning for numeric_limits<half>::has_denorm #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/ImathSetup.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ if(CMAKE_CXX_STANDARD)
endif()
set(IMATH_CXX_STANDARD "${tmp}" CACHE STRING "C++ standard to compile against")
set(tmp)
message(STATUS "Building against C++ Standard: ${IMATH_CXX_STANDARD}")

# Namespace-related settings: allows one to customize the namespace
# generated, and to version the namespaces.
Expand Down
19 changes: 18 additions & 1 deletion src/Imath/half.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,24 @@ template <> class numeric_limits<IMATH_INTERNAL_NAMESPACE::half>
static constexpr bool has_infinity = true;
static constexpr bool has_quiet_NaN = true;
static constexpr bool has_signaling_NaN = true;
static constexpr float_denorm_style has_denorm = denorm_present;

// C++23 (P2614) deprecates std::float_denorm_style and
// std::denorm_present without a replacement; std::numeric_limits still
// requires has_denorm. Scoped pragmas silence deprecation for this line
// on C++23+ toolchains; they are a no-op for C++17 / C++20.
# if defined(__clang__) || defined(__GNUC__)
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
# elif defined(_MSC_VER)
# pragma warning(push)
# pragma warning(disable : 4996)
# endif
static constexpr float_denorm_style has_denorm = denorm_present;
# if defined(__clang__) || defined(__GNUC__)
# pragma GCC diagnostic pop
# elif defined(_MSC_VER)
# pragma warning(pop)
# endif
static constexpr bool has_denorm_loss = false;
static constexpr IMATH_INTERNAL_NAMESPACE::half infinity () IMATH_NOEXCEPT
{
Expand Down
Loading