Fix issue #240: Rectangle example sets RGBA defaults on the wrong param#241
Merged
garyo merged 2 commits intoMay 27, 2026
Merged
Conversation
garyo
force-pushed
the
fix/issue-240-rectangle-defaults
branch
from
41d4058 to
44a826d
Compare
…the colour param The four kOfxParamPropDefault calls (0,0,0,1) were applied to corner2's property handle before the colour parameter was defined, so they corrupted corner2's default instead of setting the colour. Move them after the colour param is created. Signed-off-by: Gary Oberbrunner <garyo@darkstarsystems.com>
garyo
force-pushed
the
fix/issue-240-rectangle-defaults
branch
from
44a826d to
9004e66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240.
As reported by @Babakinha, the Rectangle example set the RGBA colour
default values before the
colourparameter was defined. The fourkOfxParamPropDefaultcalls therefore operated oncorner2's propertyhandle, corrupting its default instead of setting the colour to opaque
black.
This moves the four default-setting calls to immediately after the
colourparameter is created, soparamPropsrefers to the colourparam when they run. No other behavior changes.