Add PointIndexCodec, PointDataCodec and other Point changes#2197
Open
danrbailey wants to merge 6 commits intoAcademySoftwareFoundation:feature/io5from
Open
Add PointIndexCodec, PointDataCodec and other Point changes#2197danrbailey wants to merge 6 commits intoAcademySoftwareFoundation:feature/io5from
danrbailey wants to merge 6 commits intoAcademySoftwareFoundation:feature/io5from
Conversation
danrbailey
force-pushed
the
io_point_codecs
branch
from
595e1de to
cc896f6
Compare
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
danrbailey
force-pushed
the
io_point_codecs
branch
from
cc896f6 to
5897076
Compare
Signed-off-by: Dan Bailey <danbailey@ilm.com>
danrbailey
force-pushed
the
io_point_codecs
branch
from
5897076 to
5122547
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the two codecs for handling point data - PointIndexCodec and PointDataCodec.
I have also addressed the feedback that was offered previously to rename MultiPass tag class to PointDataGridMultiPass and this now locks down the old multi-pass mechanism specific to only be usable by VDB Points.
Some other related changes include removing the out-of-core atomic in AttributeArray for
ABI=14and some minor re-organisation to be able to access thereadCompressedValues()/writeCompressedValues()specializations from the new codec.