feat: add asyncDirective - #58
Open
Accudio wants to merge 3 commits into
Open
Conversation
Owner
Author
|
Hi @mickaelchanrion, could you please give this a try and see if it meets your needs? This is a rework of your PR #55 that relies more on Alpine's native async directive handling rather than extending If this looks good I'll release this as version 2.1.0 asap. |
Owner
Author
|
Test failure is due to module-crossorigin test which is not caused by this PR, and I'll look into separately. Happy to merge with that test failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new function
asyncDirectivethat allows for loading custom Alpine directives via a dynamicimport. This will wait until Alpine executes a directive before downloading it.This is very simple and just is a convenience wrapper for handling it yourself with dynamic imports, as Alpine.js supports async directives natively.
I'm not going to add conditional loading with a different API surface without significant demand for it due to amount of code for a relatively specific use-case.
Usage:
I've just added the function version at the moment and it's the most practical, I'm happy to add URL and alias if it would be useful to people.
This work is primarily developed by @mickaelchanrion, from PR #56. Thank you very much to them for the work!