fix(research): re-anchor the export sanitizer after aw-server-rust#677 streaming exports

[ErikBjare]

Fixes the two red Research Edition legs on master since the v0.14.0 submodule bump (aac77dc):

Patch research edition export hostname sanitizer
  export.rs: expected exactly one export-sanitizer insertion point, found 0

Cause

The bump pulled in ActivityWatch/aw-server-rust#677 (bounded-buffer streaming exports). Both export endpoints are now one-line calls to BucketsExportRocket::new, which spools the JSON via aw_datastore::export_to_file; no whole BucketsExport value exists at the endpoints any more, so both needles the patcher looked for (export.rs, bucket.rs) are gone. Reproduced locally by running the patcher against b0fab73.

This surfaced at the bump rather than when #677 merged because the research patch is only ever exercised against the bundle's pinned pointer — exactly the gap #1448 (nightly build against submodule masters) closes.

Fix

The sanitizer needs the whole export (fail-closed on unfiltered events; identity rewriting with cross-bucket collision detection), so it is spliced into BucketsExportRocket::new — the single point both endpoints share: re-read the spooled JSON, sanitize_buckets_export, spool again, rewind. Trade-off stated in the code: this relaxes #677's memory bound only for research builds, whose exports are category-only and small. The patcher no longer touches export.rs/bucket.rs, so endpoint churn can't break it again; a missing call site still fails closed.

Verified

• pytest scripts/tests/test_patch_research_edition_export.py — 7 pass (fixture is now the post-#677 util.rs; adds a fail-closed test for a pre-#677 tree).
• Patch applied to the real aw-server-rust submodule at b0fab73; cargo check -p aw-server compiles the inserted code. Submodule reverted afterwards.

[ErikBjare]

@greptileai review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-17T15:15:52.738180Z	889dbc5	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[greptile-apps]

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking scalability concern for large Research Edition exports.

Findings

1.  Unbounded export memory usage ▶

Summary

This PR relocates the Research Edition export sanitizer from two obsolete endpoint-level insertion points to the shared post-streaming BucketsExportRocket::new path.

• Re-reads the generated export, applies fail-closed sanitization, and serves a rewound sanitized tempfile.
• Updates patch fixtures and failure tests for the post-aw-server-rust#677 source layout.
• Retains fail-closed behavior when the expected shared insertion point is absent.
• Introduces a non-blocking scalability concern by materializing the complete export in memory.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Request[Research export request] --> Stream[export_to_file streams raw JSON]
  Stream --> Raw[(Raw tempfile)]
  Raw --> Deserialize[Deserialize complete BucketsExport]
  Deserialize --> Sanitize[Validate and rewrite identities]
  Sanitize --> Serialize[Serialize sanitized JSON]
  Serialize --> Clean[(Sanitized tempfile)]
  Clean --> Rewind[Rewind]
  Rewind --> Response[HTTP export response]

Loading

_{Reviews (1) · Last reviewed commit: "fix(research): re-anchor the export sani..."}