feat(changelog): improve Downloads section with AppImages, arm64, and Tauri - #1455
Conversation
… Tauri - Add macOS Apple Silicon (arm64) links alongside Intel - Add Linux AppImage and .deb alongside .zip - Add Tauri distribution section (experimental) noting native Wayland support - Extract base URL into variable to reduce repetition - Handle Tauri AppImage naming which omits the 'v' version prefix Closes ActivityWatch#1453 Git-Session-Id: 25fa
|
🤖 AI code reviewSafe to merge — 1 P1 disposed (rejected)Updated after inline dispositions on finding threads — this is the current state; the verdict below is frozen at review time and is kept as the historical record of that pass. Finding disposition
This PR updates the release-notes generation to add a Downloads section with Classic and Tauri distribution subsections, including new macOS arm64, Linux AppImage, and .deb links. It also updates the research-edition release-notes cleanup regex in the release workflow to strip both linked and plain-label download lines and remove the now-empty distribution sub-headings. Not safe to merge — 1 P1 openConfidence 3/5
1 finding · ❌ 1 P1❌ P1 high — The Tauri Linux AppImage link uses How this was verified: Checked the 'Package Linux (Tauri bundles)' step in .github/workflows/release.yml (lines 1186-1204): it copies to Files changed (2) — the diff as I read it
Previous review passes
Reviewed Maintainer commands
|
|
@TimeToBuildBob Dupe of #1454? |
|
@TimeToBuildBob address issues? |
Greptile flagged that the research-edition Downloads cleanup regex only matched the linked-label line form (`[**Windows**](url)`), so the new per-arch macOS/Linux lines (`**macOS**: [Intel](url) | ...`) survived cleanup and kept pointing at standard-edition filenames that don't exist on research releases. Match both forms, and drop the now-empty Classic/Tauri distribution sub-headings. Git-Session-Id: a604ad9e-eb0a-5c04-8def-2a95b4e134a2
|
Not a dupe — #1454 was a simpler earlier attempt and got closed in favor of this PR (more comprehensive: base-URL extraction, arm64, AppImage/.deb, Tauri section, correct AppImage version-string handling). On Greptile's two P1s:
The macOS-15-intel CI failure was an unrelated transient |
Addresses #1453.
Changes
.zipvprefix from the version string (e.g.activitywatch-tauri-0.14.0b7-linux-x86_64.AppImage), handled withtag.lstrip("v")Result
The generated Downloads section in release notes will now look like: