feat(autostart): preserve named profile at login - #133
Conversation
Git-Session-Id: 40c3
🤖 AI code reviewSafe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Reviewed Maintainer commands
|
Greptile SummaryThe PR makes operating-system autostart registrations profile-aware and preserves the selected named profile in the login command.
Confidence Score: 5/5The PR appears safe to merge; the previously reported shared-marker problem is fully fixed and no new actionable issues were identified. Each profile now receives a unique, validated first-run marker, while failed enablement still leaves no marker and therefore retries later. The reverse-order test confirms that a named-profile marker cannot suppress default-profile registration. The previous thread was also manually resolved after the fix. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Active aw-qt profile] --> B{Default profile?}
B -- Yes --> C[Use legacy unsuffixed registration]
B -- No --> D[Append validated profile suffix]
D --> E[Include --profile NAME in login command]
C --> F[Platform autostart backend]
E --> F
F --> G[Linux desktop entry]
F --> H[macOS LaunchAgent]
F --> I[Windows Run value]
A --> J[Profile-specific first-run marker]
Reviews (2): Last reviewed commit: "test(autostart): cover reverse sequentia..." | Re-trigger Greptile |
Git-Session-Id: adee
A named-profile marker must not skip default-profile first-run enablement.
|
@greptileai review |
Summary
Verification
PYTHONPATH=$PWD uv run --no-project --with 'pytest<9' --with 'aw-core>=0.5.18' --with 'PyQt6==6.5.3' pytest -q tests/test_autostart.py(58 passed)PYTHONPATH=$PWD uv run --no-project --with 'mypy<2' --with 'aw-core>=0.5.18' --with 'PyQt6==6.5.3' --with 'types-click' mypy aw_qt/autostart.py --ignore-missing-imports --python-version 3.9bdfe43179fbeb66090c36f7216072a142556205e