Skip to content

fix(aw-client-rust): restore toml as a regular dependency - #752

Closed
ErikBjare wants to merge 1 commit into
masterfrom
fix/aw-client-toml-dep
Closed

ErikBjare wants to merge 1 commit into
masterfrom
fix/aw-client-toml-dep

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

master doesn't build since #740: its Cargo.toml hunk replaced the toml = "0.8" line in [dependencies] with clap, leaving toml only as a dev-dependency. But aw-client-rust/src/config.rs (from #737) uses it in the library:

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `toml`
   --> aw-client-rust/src/config.rs:105:17

This puts the line back. Every open PR's CI currently fails on this (e.g. #751).

cargo clippy --workspace -- -D warnings, cargo clippy -p aw-client-rust --features cli and cargo test -p aw-client-rust pass locally.

#740 dropped toml from [dependencies] (the line was replaced by clap),
leaving it only as a dev-dependency, but src/config.rs (from #737) uses
it in the library. master no longer builds.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T18:52:21.259547Z d83d337 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Adds a dependency to the Rust client library.

The PR appears safe to merge, with only the previously reported non-blocking duplicate dependency remaining.

Findings

  1. P2 Duplicate toml dependency ▶

Summary

Restores toml as a regular dependency so the client library’s unconditional configuration module can build.

Reviews (2) · Last reviewed commit: "fix(aw-client-rust): restore toml as a r..."

Comment thread aw-client-rust/Cargo.toml
thiserror = "1.0"
dirs = "6.0"
fs4 = { version = "0.13", features = ["sync"] }
toml = "0.8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Duplicate toml dependency The new regular dependency leaves an identical toml = "0.8" entry in [dev-dependencies]. The duplicate does not affect the build, but future version or feature updates could drift between the two declarations. Please remove the redundant dev-dependency.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@ErikBjare

Copy link
Copy Markdown
Member Author

@greptileai review

@TimeToBuildBob

TimeToBuildBob commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🤖 AI code review

Adds toml = "0.8" to the [dependencies] section of aw-client-rust/Cargo.toml, restoring the normal dependency that was replaced by clap in a previous change. toml remains present in [dev-dependencies] as well. This fixes library code in src/config.rs that references the toml crate directly.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No thread-worthy findings. Advisory notes follow; they are retained without opening review threads.

1 advisory finding (summary-only, not scored)

These P2 guard, heuristic, trade-off, or documentation claims are retained for judgment without opening review threads.

⚠️ P2 medium — aw-client-rust/Cargo.toml

This is a fix(...) PR but no test files are included in the diff. Erik's feedback: 'where is the repro & fixes they are supposed to catch' (gptme#3441), 'that measurement should come with a regression test' (gptme#3446). Add a test that would have caught this bug. (Advisory: Erik merged all such PRs but consistently requested tests.)

Add a test file that reproduces the bug before the fix and passes after it.

How this was verified: static preflight: fix-commit + touched-files scan (rule 7)

Files changed (1) — the diff as I read it
  • aw-client-rust/Cargo.toml — Adds toml = "0.8" to [dependencies] after fs4; the existing dev-dependency toml = "0.8" is unchanged.

Reviewed d83d337be6a0 · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 22s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

@ErikBjare

Copy link
Copy Markdown
Member Author

Same fix as #753; either can be merged and the other closed. Note that Windows CI also fails here, in tests::test_wait_for_start_retries_without_blocking_executor (aw-client-rust, from #733): a 3 s timing-sensitive test, unrelated to this change. It couldn't run on master since #737 because master didn't build.

@ErikBjare

Copy link
Copy Markdown
Member Author

Closing in favor of #753, which restores the same toml dependency and also fixes the Windows wait_for_start test flake from #733.

@ErikBjare ErikBjare closed this Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants