Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
| thiserror = "1.0" | ||
| dirs = "6.0" | ||
| fs4 = { version = "0.13", features = ["sync"] } | ||
| toml = "0.8" |
There was a problem hiding this comment.
Duplicate toml dependency The new regular dependency leaves an identical
toml = "0.8" entry in [dev-dependencies]. The duplicate does not affect the build, but future version or feature updates could drift between the two declarations. Please remove the redundant dev-dependency.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
@greptileai review |
🤖 AI code reviewAdds Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No thread-worthy findings. Advisory notes follow; they are retained without opening review threads. 1 advisory finding (summary-only, not scored)These P2 guard, heuristic, trade-off, or documentation claims are retained for judgment without opening review threads.
This is a How this was verified: static preflight: fix-commit + touched-files scan (rule 7) Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
|
Same fix as #753; either can be merged and the other closed. Note that Windows CI also fails here, in |
master doesn't build since #740: its Cargo.toml hunk replaced the
toml = "0.8"line in[dependencies]withclap, leavingtomlonly as a dev-dependency. Butaw-client-rust/src/config.rs(from #737) uses it in the library:This puts the line back. Every open PR's CI currently fails on this (e.g. #751).
cargo clippy --workspace -- -D warnings,cargo clippy -p aw-client-rust --features cliandcargo test -p aw-client-rustpass locally.